Add flag for malfeasant scan

activation/verify_state.go

@@ -81,14 +81,6 @@ func CheckPrevATXs(ctx context.Context, logger *zap.Logger, db sql.Executor) err
 			return fmt.Errorf("add malfeasance proof: %w", err)
 		}
 
-		// h.cdb.CacheMalfeasanceProof(atx.SmesherID, proof)
-		// h.tortoise.OnMalfeasance(atx.SmesherID)
-
-		// if err = h.publisher.Publish(ctx, pubsub.MalfeasanceProof, encodedProof); err != nil {
-		// 	h.log.With().Error("failed to broadcast malfeasance proof", log.Err(err))
-		// 	return false
-		// }
-
 		count++
 	}
 	logger.Info("created malfeasance proofs", zap.Int("count", count))

cmd/root.go

@@ -79,6 +79,9 @@ func AddFlags(flagSet *pflag.FlagSet, cfg *config.Config) (configPath *string) {
 	flagSet.DurationVar(&cfg.DatabasePruneInterval, "db-prune-interval",
 		cfg.DatabasePruneInterval, "configure interval for database pruning")
 
+	flagSet.BoolVar(&cfg.ScanMalfeasantATXs, "scan-malfeasant-atxs", cfg.ScanMalfeasantATXs,
+		"scan for malfeasant ATXs")
+
 	flagSet.BoolVar(&cfg.NoMainOverride, "no-main-override",
 		cfg.NoMainOverride, "force 'nomain' builds to run on the mainnet")
 

config/config.go

@@ -124,6 +124,9 @@ type BaseConfig struct {
 
 	PruneActivesetsFrom types.EpochID `mapstructure:"prune-activesets-from"`
 
+	// ScanMalfeasantATXs is a flag to enable scanning for malfeasant ATXs.
+	ScanMalfeasantATXs bool `mapstructure:"scan-malfeasant-atxs"`
+
 	NetworkHRP string `mapstructure:"network-hrp"`
 
 	// MinerGoodAtxsPercent is a threshold to decide if tortoise activeset should be

config/mainnet.go

@@ -73,7 +73,8 @@ func MainnetConfig() Config {
 			DatabaseConnections:   16,
 			DatabasePruneInterval: 30 * time.Minute,
 			DatabaseVacuumState:   15,
-			PruneActivesetsFrom:   12, // starting from epoch 13 activesets below 12 will be pruned
+			PruneActivesetsFrom:   12,    // starting from epoch 13 activesets below 12 will be pruned
+			ScanMalfeasantATXs:    false, // opt-in
 			NetworkHRP:            "sm",
 
 			LayerDuration:  5 * time.Minute,

node/node.go

@@ -1892,13 +1892,14 @@ func (app *App) setupDBs(ctx context.Context, lg log.Log) error {
 		datastore.WithConfig(app.Config.Cache),
 	)
 
-	// TODO(mafa): add command line flag to trigger this instead of always running it
-	app.log.With().Info("checking DB for malicious ATXs")
-	start = time.Now()
-	if err := activation.CheckPrevATXs(ctx, app.log.Zap(), app.db); err != nil {
-		return fmt.Errorf("malicious ATX check: %w", err)
+	if app.Config.ScanMalfeasantATXs {
+		app.log.With().Info("checking DB for malicious ATXs")
+		start = time.Now()
+		if err := activation.CheckPrevATXs(ctx, app.log.Zap(), app.db); err != nil {
+			return fmt.Errorf("malicious ATX check: %w", err)
+		}
+		app.log.With().Info("malicious ATX check completed", log.Duration("duration", time.Since(start)))
 	}
-	app.log.With().Info("malicious ATX check completed", log.Duration("duration", time.Since(start)))
 
 	migrations, err = sql.LocalMigrations()
 	if err != nil {