Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: let's specify how terragrunt block works in case stack isn't terragrunt #594

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

truszkowski
Copy link
Contributor

Description of the change

spacelift-io/terraform-provider-spacelift#540 (comment)
The customer suggested that it's not obvious terragrunt block isn't applied for different (Terraform, Ansible... ) stack types.
Especially, it makes sense for monorepos, where we could mix different configurations.

Checklist

Please make sure that the proposed change checks all the boxes below before requesting a review:

  • I have reviewed the guidelines for contributing to this repository.
  • The preview looks fine.
  • The tests pass.
  • The commit history is clean and meaningful.
  • The pull request is opened against the main branch.
  • The pull request is no longer marked as a draft.
  • You agree to license your contribution under the MIT license to Spacelift (not required for Spacelift employees).
  • You have updated the navigation files correctly:
    • No new pages have been added, or;
    • Only nav.yaml has been updated because the changes only apply to SaaS, or;
    • Only nav.self-hosted.yaml has been updated because the changes only apply to Self-Hosted, or;
    • Both nav.yaml and nav.self-hosted.yaml have been updated.

If the proposed change is ready to be merged, please request a review from @spacelift-io/solutions-engineering. Someone will review and merge the pull request.

Spacelift employees should request reviews from the relevant engineers and are allowed to merge pull requests after they got at least one approval.

Thank you for your contribution! 🙇

Copy link

render bot commented Aug 26, 2024

@truszkowski truszkowski requested review from a team August 26, 2024 12:09
@truszkowski truszkowski force-pushed the CU-8695h7wwf-additional-info-for-configyaml-terragrunt branch from eaacbaf to 5f64c14 Compare August 28, 2024 19:24
@truszkowski truszkowski requested review from a team and Apollorion August 28, 2024 19:25
peterdeme
peterdeme previously approved these changes Aug 28, 2024
…md - Terragrunt instead of terra grunt

Co-authored-by: Peter Deme <[email protected]>
Copy link
Contributor

@adamconnelly adamconnelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we'd be better adding a section called "Stack Vendor" or something like that, that explains the interaction between the vendor of your stack, and the config options. The reason I say this is that currently this info banner is inside the Terragrunt section, but in reality it's not a Terragrunt-specific piece of information because the same could apply for different vendor types.

The thing is it's a bit weird right now because the only vendor-specific options we expose currently are for Terragrunt. I'm just thinking it might be easier for people to understand the docs that way, and also if we exposed settings for other vendors in future the docs would still make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants