-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: let's specify how terragrunt block works in case stack isn't terragrunt #594
base: main
Are you sure you want to change the base?
fix: let's specify how terragrunt block works in case stack isn't terragrunt #594
Conversation
Your Render PR Server URL is https://spacelift-user-documentation-pr-594.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cr670ng8fa8c73ar99eg. |
…md - better wording Co-authored-by: Joey Stout <[email protected]>
eaacbaf
to
5f64c14
Compare
…md - Terragrunt instead of terra grunt Co-authored-by: Peter Deme <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we'd be better adding a section called "Stack Vendor" or something like that, that explains the interaction between the vendor of your stack, and the config options. The reason I say this is that currently this info banner is inside the Terragrunt section, but in reality it's not a Terragrunt-specific piece of information because the same could apply for different vendor types.
The thing is it's a bit weird right now because the only vendor-specific options we expose currently are for Terragrunt. I'm just thinking it might be easier for people to understand the docs that way, and also if we exposed settings for other vendors in future the docs would still make sense.
Description of the change
spacelift-io/terraform-provider-spacelift#540 (comment)
The customer suggested that it's not obvious
terragrunt
block isn't applied for different (Terraform, Ansible... ) stack types.Especially, it makes sense for monorepos, where we could mix different configurations.
Checklist
Please make sure that the proposed change checks all the boxes below before requesting a review:
main
branch.If the proposed change is ready to be merged, please request a review from
@spacelift-io/solutions-engineering
. Someone will review and merge the pull request.Spacelift employees should request reviews from the relevant engineers and are allowed to merge pull requests after they got at least one approval.
Thank you for your contribution! 🙇