Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce support for context hooks #443

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Introduce support for context hooks #443

merged 2 commits into from
Nov 16, 2023

Conversation

marcinwyszynski
Copy link
Contributor

@marcinwyszynski marcinwyszynski commented Mar 25, 2023 •
edited
Loading

Type of change

  • New feature (non-breaking change that adds functionality)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development
  • Examples for new resources and data sources have been added
  • Default values have been documented in the description (e.g., "Dummy: (Boolean) Blah blah. Defaults to false.)
  • If the action fails that checks the documentation: Run go generate to make sure the docs are up to date

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Pull Request is no longer marked as "draft"
  • Reviewers have been assigned
  • Changes have been reviewed by at least one other engineer

@marcinwyszynski marcinwyszynski force-pushed the context-hooks branch 3 times, most recently from a99b88c to c92b2a2 Compare March 25, 2023 11:48
@marcinwyszynski marcinwyszynski marked this pull request as ready for review March 25, 2023 12:19
@marcinwyszynski marcinwyszynski self-assigned this Nov 16, 2023
@marcinwyszynski marcinwyszynski changed the title Introduce experimental support for context hooks Introduce support for context hooks Nov 16, 2023
@marcinwyszynski marcinwyszynski merged commit 4961bcb into main Nov 16, 2023
7 checks passed
@marcinwyszynski marcinwyszynski deleted the context-hooks branch November 16, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KNiepok KNiepok KNiepok approved these changes

@adamconnelly adamconnelly adamconnelly approved these changes

Assignees

@marcinwyszynski marcinwyszynski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcinwyszynski @adamconnelly @KNiepok