Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: uses autoscaler module instead of repeating code #108

Merged
merged 10 commits into from
Jan 10, 2025

Conversation

jubranNassar
Copy link
Contributor

@jubranNassar jubranNassar commented Jan 6, 2025

Description of the change

This PR removes all the duplicated code from the autoscaler repo and calls it instead

Type of change

  • Bug fix (non-breaking change that fixes an issue);
  • New feature (non-breaking change that adds functionality);
  • Breaking change (fix or feature that would cause existing functionality to not work as expected);
  • Documentation (a documentation or example fix not affecting the infrastructure managed by this module);

Checklists

Development

  • All necessary variables have been defined, with defaults if applicable;
  • The code is formatted properly;

Code review

  • The module version is bumped accordingly;
  • Spacelift tests are passing;
  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached;
  • This pull request is no longer marked as "draft";
  • Reviewers have been assigned;
  • Changes have been reviewed by at least one other engineer;

@jubranNassar jubranNassar requested a review from a team as a code owner January 6, 2025 21:40
@jubranNassar jubranNassar force-pushed the move-autoscaling-logic branch from ccf916b to 846f18c Compare January 6, 2025 21:48
sephriot
sephriot previously approved these changes Jan 7, 2025
@sephriot sephriot self-requested a review January 10, 2025 06:40
@jubranNassar jubranNassar merged commit fbb44d2 into spacelift-io:master Jan 10, 2025
5 checks passed
@lorengordon
Copy link
Contributor

lorengordon commented Jan 10, 2025

This creates a unversioned dependency on the autoscaler module. Changes to that repo will be picked up by users of this module without any increment to the version of this module. From one init to the next, suddenly this module may do different things. I really try to avoid that kind of "automatic" implicit dependency update. Can you please at least pin the version in the module block?

Or, better in my opinion, reverse the dependency. The upstream module should invoke this project. This project is the terraform module, and specializes in terraform syntax. The upstream project is just the lambda function code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants