FEATURE: Add instance market options support for the ASG launch template #107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This change adds a new feature to be able to request instance_market_options to the launch template creation. Currently this TF module uses a 3rd party module which supports the option to create spot instances. Spot instances are a perfect use case for runners which sit idle a lot of the time. With the support of the new variable, you can now request SPOT EC2s by adding the following code to the module.
instance_market_options = { market_type = "spot"
}This change allows the variable to be passed from module to module. We use spot instances all the time and have had to manually update the template. This change will add spot instance support to this module. I have tested this on my fork
Type of change
Checklists
Development
Code review