Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Add instance market options support for the ASG launch template #107

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

garym-krrv
Copy link

@garym-krrv garym-krrv commented Dec 3, 2024

Description of the change

This change adds a new feature to be able to request instance_market_options to the launch template creation. Currently this TF module uses a 3rd party module which supports the option to create spot instances. Spot instances are a perfect use case for runners which sit idle a lot of the time. With the support of the new variable, you can now request SPOT EC2s by adding the following code to the module.

instance_market_options = { market_type = "spot" }

This change allows the variable to be passed from module to module. We use spot instances all the time and have had to manually update the template. This change will add spot instance support to this module. I have tested this on my fork

Type of change

  • Bug fix (non-breaking change that fixes an issue);
  • New feature (non-breaking change that adds functionality);
  • Breaking change (fix or feature that would cause existing functionality to not work as expected);
  • Documentation (a documentation or example fix not affecting the infrastructure managed by this module);

Checklists

Development

  • All necessary variables have been defined, with defaults if applicable;
  • The code is formatted properly;

Code review

  • The module version is bumped accordingly;
  • Spacelift tests are passing;
  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached;
  • This pull request is no longer marked as "draft";
  • Reviewers have been assigned;
  • Changes have been reviewed by at least one other engineer;

@garym-krrv garym-krrv requested a review from a team as a code owner December 3, 2024 16:18
@garym-krrv garym-krrv changed the title FEATURE Add instance market options support for the ASG FEATURE: Add instance market options support for the ASG Dec 3, 2024
@garym-krrv garym-krrv changed the title FEATURE: Add instance market options support for the ASG FEATURE: Add instance market options support for the ASG launch template Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants