Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(asg): update to 8.x #105

Merged
merged 2 commits into from
Nov 20, 2024
Merged

chore(asg): update to 8.x #105

merged 2 commits into from
Nov 20, 2024

Conversation

adamconnelly
Copy link
Contributor

@adamconnelly adamconnelly commented Nov 20, 2024

Description of the change

This PR is actually a follow-up from this PR by @jeohist: #102.

The problem is that the AWS version that our examples are pinned to isn't compatible with the latest version of the module. I've just gone ahead and added another commit on top of @jeohist's change to fix that since it's tricky for external contributors to run the test cases.

Type of change

  • Bug fix (non-breaking change that fixes an issue);
  • New feature (non-breaking change that adds functionality);
  • Breaking change (fix or feature that would cause existing functionality to not work as expected);
  • Documentation (a documentation or example fix not affecting the infrastructure managed by this module);

Checklists

Development

  • All necessary variables have been defined, with defaults if applicable;
  • The code is formatted properly;

Code review

  • The module version is bumped accordingly;
  • Spacelift tests are passing;
  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached;
  • This pull request is no longer marked as "draft";
  • Reviewers have been assigned;
  • Changes have been reviewed by at least one other engineer;

7.x no longer supports AWS 4.x
The new version of the ASG module requires a newer version of the AWS provider.
@adamconnelly adamconnelly marked this pull request as ready for review November 20, 2024 16:03
@adamconnelly adamconnelly requested a review from a team as a code owner November 20, 2024 16:03
@adamconnelly adamconnelly requested a review from a team November 20, 2024 16:03
@jeohist jeohist mentioned this pull request Nov 20, 2024
9 tasks
@adamconnelly adamconnelly merged commit d6ead17 into master Nov 20, 2024
5 checks passed
@adamconnelly adamconnelly deleted the update_asg_module branch November 20, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants