fix: Changed disable_container_credentials default to true (#112)

* feat: Changed disable_container_credentials default to true Signed-off-by: Jakub <[email protected]> * Version bumped up Signed-off-by: Jakub <[email protected]> * Readme Signed-off-by: Jakub <[email protected]> * Version update Signed-off-by: Jakub <[email protected]> --------- Signed-off-by: Jakub <[email protected]>
spacelift-io · Jan 24, 2025 · 74d402b · 74d402b
1 parent fbb44d2
commit 74d402b
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/.spacelift/config.yml b/.spacelift/config.yml
@@ -1,5 +1,5 @@
 version: 1
-module_version: 2.7.0
+module_version: 2.8.0
 tests:
   - name: AMD64-based workerpool
     project_root: examples/amd64

diff --git a/README.md b/README.md
@@ -110,7 +110,7 @@ $ make docs
 | <a name="input_configuration"></a> [configuration](#input\_configuration) | User configuration. This allows you to decide how you want to pass your token<br>  and private key to the environment - be that directly, or using SSM Parameter<br>  Store, Vault etc. Ultimately, here you need to export SPACELIFT\_TOKEN and<br>  SPACELIFT\_POOL\_PRIVATE\_KEY to the environment. | `string` | n/a | yes |
 | <a name="input_create_iam_role"></a> [create\_iam\_role](#input\_create\_iam\_role) | Determines whether an IAM role is created or to use an existing IAM role | `bool` | `true` | no |
 | <a name="input_custom_iam_role_name"></a> [custom\_iam\_role\_name](#input\_custom\_iam\_role\_name) | Name of an existing IAM to use. Used `when create_iam_role` = `false` | `string` | `""` | no |
-| <a name="input_disable_container_credentials"></a> [disable\_container\_credentials](#input\_disable\_container\_credentials) | If true, the run container will not be able to access the instance profile<br>  credentials by talking to the EC2 metadata endpoint. This is done by setting<br>  the number of hops in IMDSv2 to 1. Since the Docker container goes through an<br>  extra NAT step, this still allows the launcher to talk to the endpoint, but<br>  prevents the container from doing so. | `bool` | `false` | no |
+| <a name="input_disable_container_credentials"></a> [disable\_container\_credentials](#input\_disable\_container\_credentials) | If true, the run container will not be able to access the instance profile<br>  credentials by talking to the EC2 metadata endpoint. This is done by setting<br>  the number of hops in IMDSv2 to 1. Since the Docker container goes through an<br>  extra NAT step, this still allows the launcher to talk to the endpoint, but<br>  prevents the container from doing so. | `bool` | `true` | no |
 | <a name="input_domain_name"></a> [domain\_name](#input\_domain\_name) | Top-level domain name to use for pulling the launcher binary | `string` | `"spacelift.io"` | no |
 | <a name="input_ec2_instance_type"></a> [ec2\_instance\_type](#input\_ec2\_instance\_type) | EC2 instance type for the workers. If an arm64-based AMI is used, this must be an arm64-based instance type. | `string` | `"t3.micro"` | no |
 | <a name="input_enable_autoscaling"></a> [enable\_autoscaling](#input\_enable\_autoscaling) | Determines whether to create the Lambda Autoscaler function and dependent resources or not | `bool` | `true` | no |

diff --git a/variables.tf b/variables.tf
@@ -23,7 +23,7 @@ variable "disable_container_credentials" {
   extra NAT step, this still allows the launcher to talk to the endpoint, but
   prevents the container from doing so.
   EOF
-  default     = false
+  default     = true
 }
 
 variable "autoscaling_group_arn" {