Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Article summary - OpenAI Integration #399

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anod
Copy link
Contributor

@anod anod commented Oct 24, 2024

Add summarize feature which fetching an article content and summarizes it using OpenAI API.
Api key needs to be provided in the settings

image
image
image

@anod
Copy link
Contributor Author

anod commented Oct 24, 2024

@spacecowboy please take a look

@spacecowboy spacecowboy self-requested a review October 24, 2024 21:43
@spacecowboy
Copy link
Owner

Sure. Let me know when you think the functionality is done.

The structure seems reasonable. I noted some hard-coded english strings and some lack of padding in layouts, but I'll hold off on reviewing in detail until later.

What issues are you having with "theming of buttons and progress bars"?

@anod anod marked this pull request as ready for review October 26, 2024 10:13
@anod
Copy link
Contributor Author

anod commented Oct 26, 2024

Sure. Let me know when you think the functionality is done.

The structure seems reasonable. I noted some hard-coded english strings and some lack of padding in layouts, but I'll hold off on reviewing in detail until later.

What issues are you having with "theming of buttons and progress bars"?

theme is not being applied
image
image

@anod anod changed the title [Draft] Article summary -OpenAI Integration Article summary - OpenAI Integration Oct 26, 2024
@spacecowboy
Copy link
Owner

Theme isn't applying because you are importing the wrong assets.

import androidx.compose.material.LinearProgressIndicator

Only import material3 assets.

Exception to that is things from the icons library. But everything else should only be material3

@anod
Copy link
Contributor Author

anod commented Nov 2, 2024

Thanks forgot about material 1

@spacecowboy spacecowboy marked this pull request as draft November 3, 2024 02:39
@spacecowboy
Copy link
Owner

Converted the PR to a draft. Please let me know when it's ready for review

@anod
Copy link
Contributor Author

anod commented Nov 3, 2024

Converted the PR to a draft. Please let me know when it's ready for review

What's missing? I don't plan to add anything

@spacecowboy
Copy link
Owner

spacecowboy commented Nov 5, 2024

Converted the PR to a draft. Please let me know when it's ready for review

What's missing? I don't plan to add anything

Well CI is failing for one.

  • Please run ./gradlew ktlintformat
  • Please remove all hard coded english strings and make proper string resources
  • Fix material1 imports to be material3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants