Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the scaling of small thumbnails #347

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ymcx
Copy link

@ymcx ymcx commented Aug 8, 2024

Small images appear to not scale correctly when Precision.INEXACT is used rather than Precision.EXACT. As you can see from the images below, with the fix applied the thumbnails scale to fit the frame rather than having the huge border shown.
Please note that the feed is somewhat broken and their thumbnails are low quality and sometimes stretched.
1
2

@spacecowboy
Copy link
Owner

The border is actually intentional. Personally, I preferred to see the images small and clear instead of large and pixly.

Perhaps it could be a setting if you agree?

@ymcx
Copy link
Author

ymcx commented Aug 8, 2024

The border is actually intentional. Personally, I preferred to see the images small and clear instead of large and pixly.

Perhaps it could be a setting if you agree?

The 'compact card' layout seems to hande thumbnails by resizing them to the image boundaries, which is why I initially thought the current approach wasn't intentional.

However, I totally see your point about not wanting them to become blurry since like in my example, your feed starts getting really ugly if it's filled with entries with low resolution images.

A setting to either
a) hide all of the thumbnails in a given feed or
b) force the thumbnails to the size of the frame like in the initial commit or maybe even
c) both
would probably be sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants