Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show unread article count in title #300

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

svenjacobs
Copy link
Contributor

As suggested here I started with a rather simple feature and added an option to display the unread article count in the title bar.

If you like I can further improve this PR and make the unread count a little bit smaller?

Hope you like it.

@spacecowboy
Copy link
Owner

Nice work @svenjacobs . Overall it looks good. Run ./gradlew ktlintformat on it though

@svenjacobs
Copy link
Contributor Author

Run ./gradlew ktlintformat on it though

Done. I fixed the formatting.

@svenjacobs
Copy link
Contributor Author

Going to fix the tests, too 👀

@svenjacobs
Copy link
Contributor Author

Tests are fixed.

@spacecowboy spacecowboy merged commit a42529e into spacecowboy:master Jun 10, 2024
2 checks passed
@svenjacobs svenjacobs deleted the feature/title_unread_count branch June 10, 2024 17:08
@svenjacobs
Copy link
Contributor Author

@spacecowboy Unfortunately I found a bug with this implementation. When a group is selected, the unread count of "all feeds" will be displayed in the title and not the one of the group. I will have a look 👀

@spacecowboy
Copy link
Owner

@spacecowboy Unfortunately I found a bug with this implementation. When a group is selected, the unread count of "all feeds" will be displayed in the title and not the one of the group. I will have a look 👀

Yes that's correct. getUnreadCount does not take tags into account. Simply passing the tag along should fix that.

@svenjacobs
Copy link
Contributor Author

You're right. The fix was pretty simple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants