Implement Pomelo #1049
Implement Pomelo #1049
Conversation
There was a problem hiding this comment.
global_name field is the display name. Usernames are going to still use the username field (see discord docs PR https://github.com/discord/discord-api-docs/pull/6130/files/9a162cf08604dc39b10d65f715ed1d87b6b52678#diff-39e6aeaafba5726f3fb409da21a6953dfb679480f09038a0d05f4dd93e89e074)
I also found that docs pr after I wrote this, I'll have to remove the display_name property since it doesn't seem like it's going to be used. |
Those are only going to be used during migration; in spacebar, we might instead want to do an automated migration to unique names. |
Puyodead1
force-pushed
the
dev/pomelo
branch
from
23e7538
to
99963e1
Compare
Puyodead1
force-pushed
the
dev/pomelo
branch
from
85435b7
to
d88e927
Compare
|
from @Puyodead1:
I still think this should be allowed, but without full round-tripping compatibility. Discriminators to unique usernames is already a lossy conversion in itself. |
No it's not? As I said in discord, we can just simply not delete discriminators from the db,and with legacy username (users without one could just keep what they have) |
| @@ -115,6 +115,7 @@ export const Email: { | |||
| const replacements = [ | |||
| ["{instanceName}", instanceName], | |||
| ["{userUsername}", user.username], | |||
| ["{userGlobalName}", user.global_name], | |||
There was a problem hiding this comment.
this will need to be added to our docs
| if (!x.author) | ||
| x.author = User.create({ | ||
| id: "4", | ||
| discriminator: "0000", | ||
| username: "Spacebar Ghost", | ||
| discriminator: uniqueUsernames ? "0" : "0000", |
There was a problem hiding this comment.
it might be easier to just change the ghost id to be 0 always instead lol
The Pomelo project is the code name for Discords new naming system. Pomelo removes the use of discriminators and introduces new, unique usernames (@username) and display names.
The official API docs are still being written, so all changes are based on information the below articles, observing changes in the Discord API, and the partial WIP docs.
global_nameuser propertyuniqueUsernames)References: