-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paramedic Void Suit update #34657
base: master
Are you sure you want to change the base?
Paramedic Void Suit update #34657
Conversation
Added light to the paramedic void suit helmet Added siren with light to the paramedic void suit
RSI Diff Bot; head commit 4f821bb merging into f69f5c1 Resources/Textures/Clothing/Head/Helmets/paramedhelm.rsi
Resources/Textures/Clothing/Head/Hardsuits/paramedhelm.rsi
Resources/Textures/Clothing/OuterClothing/Hardsuits/paramed.rsi
|
Isn't the difference between a soft and hardsuit the damage protection and slowdown? |
The old code has a comment that says |
The light shouldn’t be on the antennae. The antennae is way too thin for that and serves a different function. Also, should probably have a custom icon for the siren action. |
Where would you suggest the light be then? |
changed the light placement |
No mixels. Fix the sprite size to be consistent with the other actions (32x32) |
so I listened to the alarm siren and it is... even more annoying then the justice helm. idk how it sounds in-game but it is LOUD in your video. but I think it needs a diffrent sound. |
the icon-siren is 32x32, but if you don't like it, i can try make a new one.
On my end they are the same volume as the justice helmet. If you have a suggestion for a different sound that has the proper licenses we can use, feel free to link it. |
icon-siren should look like it is 32x32 because you're bunching the pixels together to give the illusion of it being lower res |
the sprites a bit weird but yes |
From my limited understanding a void suit, compared to a hardsuit, allows faster movement and is smaller and thus easier to transport in a bag. This came from discourse when RD's suit size was nerfed |
As I mentioned in a previous comment, from my understanding, it was only in the softsuits YML because it parented off the EVA suit, The RD's suit is on the hardsuits YML Now that you mentioned being able to put it in a bag, noticed I accidently removed the ability to put it in one, so i'll do a commit fixing that. (must have been when I was solving the instantaction issues) I am not alreatering any of the names, armor or speed modifiers that the suit has, am simply moving it to the hardsuiits YML because my changes to have it have a flashlight changes the parent to hardsuit instead of eva suit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small things
Resources/Prototypes/Entities/Clothing/Head/hardsuit-helmets.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/Entities/Clothing/OuterClothing/hardsuits.yml
Outdated
Show resolved
Hide resolved
Will still need an official arttainer review |
also CL was lacking a space, unsure if that matters but i fixed it for you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Get approved nerd. Will need an arttainer approval still however.
art approval |
@@ -342,6 +342,47 @@ | |||
radius: 7 | |||
energy: 3 | |||
|
|||
#Paramedic Void Helmet | |||
- type: entity | |||
parent: ClothingHeadHardsuitWithLightBase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by reparenting the paramedic suit to the hardsuit you are changing its pressure protection stats
instead of turning it into a hardsuit I would split off all the components responsible for the helmet light into a new base parent and have both the hardsuits and softsuits inherit that when needed
I also think the siren sound is a little hard on the ears. Could you maybe try finding another sound effect for it? |
hopefully the new sound is better |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I just had some nitpicks (so original of me). I also had a question for where your new sprites are from, as you must attribute them all.
Enjoy!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Where are these sprites from? I wasn't easily able to find this sprite from paradise, so I'm assuming this may be from a different source?
If they are from another source, you'll need to add it to the RSI's meta.json's copyright field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i just edited the existing sprite for the paramedic void suit myself, same for the siren icon
{ | ||
"name": "icon-siren-light", | ||
"delays": [ | ||
[ | ||
0.1, | ||
0.1, | ||
0.1, | ||
0.1 | ||
] | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: There seems to be weird indentation here, so please make sure it's fixed.
Also, some of the lines have tabs which we don't use -- please use spaces instead (just use the number of spaces to match the indentation of the rest of the file).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that indentention is copied from justice helmet, since i couldn't get the animated icon to work, i will just remove that sprite state
- type: Sprite | ||
sprite: Clothing/OuterClothing/Hardsuits/paramed.rsi | ||
layers: | ||
- state: icon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: This line is indented incorrectly.
About the PR
Moved the paramedic void suit outof the softsuit yml and moved it into the hardsuit yml
Made it restricted to medical (to be in line with the other deparment-specific hardsuits)
Added flashlight to its helmet
Added rotating blue light with siren sound to the suit (similar to the justice helmet)
Why / Balance
It was the only hardsuit (to my knowledge) that didn't have flashlight.
And being such a limited item per station, I though it would be nice to give it an ambulance siren.
Technical details
Moved ClothingOuterHardsuitVoidParamed and ClothingHeadHelmetVoidParamed from softsuit/EVA to the hardsuit .yml's
Added ambulancesiren.ogg and updated attributions .yml in its folder
Media
https://youtu.be/XnXVAvqczww
Note: the graphics in the video are outdated, the light is now from the side of the helmet instead of the antenna
Requirements
Breaking changes
None as far as I am aware.
Changelog
🆑