Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paramedic Void Suit update #34657

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

Velken
Copy link
Contributor

@Velken Velken commented Jan 26, 2025

About the PR

Moved the paramedic void suit outof the softsuit yml and moved it into the hardsuit yml
Made it restricted to medical (to be in line with the other deparment-specific hardsuits)
Added flashlight to its helmet
Added rotating blue light with siren sound to the suit (similar to the justice helmet)

Why / Balance

It was the only hardsuit (to my knowledge) that didn't have flashlight.
And being such a limited item per station, I though it would be nice to give it an ambulance siren.

Technical details

Moved ClothingOuterHardsuitVoidParamed and ClothingHeadHelmetVoidParamed from softsuit/EVA to the hardsuit .yml's
Added ambulancesiren.ogg and updated attributions .yml in its folder

Media

https://youtu.be/XnXVAvqczww

Note: the graphics in the video are outdated, the light is now from the side of the helmet instead of the antenna

Requirements

Breaking changes

None as far as I am aware.

Changelog

🆑

  • add: Paramedic Void Suit now has flashlight and an ambulance siren.
  • tweak: Paramedic Void Suit is now restricted to Medical.

Added light to the paramedic void suit helmet
Added siren with light to the paramedic void suit
@github-actions github-actions bot added Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. Changes: Audio Changes: Might require knowledge of audio. size/M Denotes a PR that changes 100-999 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 26, 2025
Copy link
Contributor

github-actions bot commented Jan 26, 2025

RSI Diff Bot; head commit 4f821bb merging into f69f5c1
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Clothing/Head/Helmets/paramedhelm.rsi

State Old New Status
icon Removed
inhand-left Removed
inhand-right Removed

Resources/Textures/Clothing/Head/Hardsuits/paramedhelm.rsi

State Old New Status
equipped-head-light-vox Added
equipped-head-light Added
icon-flash Added
icon Added
light-overlay Added

Resources/Textures/Clothing/OuterClothing/Hardsuits/paramed.rsi

State Old New Status
icon-siren-light Added
icon-siren Added

Edit: diff updated after 4f821bb

@slarticodefast
Copy link
Member

slarticodefast commented Jan 26, 2025

Isn't the difference between a soft and hardsuit the damage protection and slowdown?
So it would still be a softsuit since it gives no protection against brute damage.

@Velken
Copy link
Contributor Author

Velken commented Jan 26, 2025

Isn't the difference between a soft and hardsuit the damage protection and slowdown? So it would still be a softsuit since it gives no protection against brute damage.

The old code has a comment that says
"Despite having resistances and looking like a hardsuit, this parents off the EVA suit so it goes here."
The old one already has slowdown and protection values, just not for brute damage.
Plus, it looks and behaves more like a hardsuit than a softsuit.

@UbaserB
Copy link
Member

UbaserB commented Jan 26, 2025

The light shouldn’t be on the antennae. The antennae is way too thin for that and serves a different function.

Also, should probably have a custom icon for the siren action.

@Velken
Copy link
Contributor Author

Velken commented Jan 26, 2025

The light shouldn’t be on the antennae. The antennae is way too thin for that and serves a different function.

Also, should probably have a custom icon for the siren action.

Where would you suggest the light be then?

@UbaserB
Copy link
Member

UbaserB commented Jan 26, 2025

IMG_6898

@Velken
Copy link
Contributor Author

Velken commented Jan 26, 2025

IMG_6898

ooooh, i like that, i'll update the sprite after in a bit and also make a custom icon for the siren

@Velken
Copy link
Contributor Author

Velken commented Jan 26, 2025

changed the light placement
but i couldn't figure out how to change the action bar icon for the siren

@ArtisticRoomba ArtisticRoomba added P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content S: Needs Review Status: Requires additional reviews before being fully accepted DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: Engineering Area: Engineering department, including Atmospherics. A: Medical Area: Medical department, including Chemistry and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. A: Engineering Area: Engineering department, including Atmospherics. labels Jan 27, 2025
@Velken
Copy link
Contributor Author

Velken commented Jan 27, 2025

fixed the siren icon, thanks to, Milon, KeronSHB and Orks (Beck T) on discord for helping out
2025-01-26-22 11 10-Content Client

@Velken
Copy link
Contributor Author

Velken commented Jan 27, 2025

made siren icon BigAction size
image

@UbaserB
Copy link
Member

UbaserB commented Jan 27, 2025

made siren icon BigAction size

No mixels. Fix the sprite size to be consistent with the other actions (32x32)

@walksanatora
Copy link

so I listened to the alarm siren and it is... even more annoying then the justice helm. idk how it sounds in-game but it is LOUD in your video. but I think it needs a diffrent sound.

@Velken
Copy link
Contributor Author

Velken commented Jan 27, 2025

made siren icon BigAction size

No mixels. Fix the sprite size to be consistent with the other actions (32x32)

the icon-siren is 32x32, but if you don't like it, i can try make a new one.

so I listened to the alarm siren and it is... even more annoying then the justice helm. idk how it sounds in-game but it is LOUD in your video. but I think it needs a diffrent sound.

On my end they are the same volume as the justice helmet. If you have a suggestion for a different sound that has the proper licenses we can use, feel free to link it.

@UbaserB
Copy link
Member

UbaserB commented Jan 27, 2025

icon-siren should look like it is 32x32 because you're bunching the pixels together to give the illusion of it being lower res

@Velken
Copy link
Contributor Author

Velken commented Jan 27, 2025

icon-siren should look like it is 32x32 because you're bunching the pixels together to give the illusion of it being lower res
would this be better?

image

image

@UbaserB
Copy link
Member

UbaserB commented Jan 27, 2025

the sprites a bit weird but yes

@Velken
Copy link
Contributor Author

Velken commented Jan 27, 2025

the sprites a bit weird but yes
in-game look

image

@superjj18
Copy link

superjj18 commented Jan 27, 2025

From my limited understanding a void suit, compared to a hardsuit, allows faster movement and is smaller and thus easier to transport in a bag.

This came from discourse when RD's suit size was nerfed

@Velken
Copy link
Contributor Author

Velken commented Jan 27, 2025

As I mentioned in a previous comment, from my understanding, it was only in the softsuits YML because it parented off the EVA suit,

The RD's suit is on the hardsuits YML

Now that you mentioned being able to put it in a bag, noticed I accidently removed the ability to put it in one, so i'll do a commit fixing that. (must have been when I was solving the instantaction issues)

I am not alreatering any of the names, armor or speed modifiers that the suit has, am simply moving it to the hardsuiits YML because my changes to have it have a flashlight changes the parent to hardsuit instead of eva suit.

Copy link
Contributor

@ScarKy0 ScarKy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small things

@ScarKy0
Copy link
Contributor

ScarKy0 commented Jan 28, 2025

Will still need an official arttainer review

@ScarKy0 ScarKy0 self-assigned this Jan 28, 2025
@ScarKy0
Copy link
Contributor

ScarKy0 commented Jan 28, 2025

also CL was lacking a space, unsure if that matters but i fixed it for you

Copy link
Contributor

@ScarKy0 ScarKy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get approved nerd. Will need an arttainer approval still however.

@ScarKy0 ScarKy0 added S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. and removed S: Needs Review Status: Requires additional reviews before being fully accepted labels Jan 28, 2025
@Emisse
Copy link
Contributor

Emisse commented Jan 28, 2025

art approval

@@ -342,6 +342,47 @@
radius: 7
energy: 3

#Paramedic Void Helmet
- type: entity
parent: ClothingHeadHardsuitWithLightBase
Copy link
Member

@slarticodefast slarticodefast Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by reparenting the paramedic suit to the hardsuit you are changing its pressure protection stats
instead of turning it into a hardsuit I would split off all the components responsible for the helmet light into a new base parent and have both the hardsuits and softsuits inherit that when needed

@slarticodefast
Copy link
Member

I also think the siren sound is a little hard on the ears. Could you maybe try finding another sound effect for it?

@Velken
Copy link
Contributor Author

Velken commented Jan 28, 2025

I also think the siren sound is a little hard on the ears. Could you maybe try finding another sound effect for it?

hopefully the new sound is better

Copy link
Contributor

@Aeshus Aeshus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I just had some nitpicks (so original of me). I also had a question for where your new sprites are from, as you must attribute them all.

Enjoy!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Where are these sprites from? I wasn't easily able to find this sprite from paradise, so I'm assuming this may be from a different source?

If they are from another source, you'll need to add it to the RSI's meta.json's copyright field.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i just edited the existing sprite for the paramedic void suit myself, same for the siren icon

Comment on lines +16 to +25
{
"name": "icon-siren-light",
"delays": [
[
0.1,
0.1,
0.1,
0.1
]
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: There seems to be weird indentation here, so please make sure it's fixed.

Also, some of the lines have tabs which we don't use -- please use spaces instead (just use the number of spaces to match the indentation of the rest of the file).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that indentention is copied from justice helmet, since i couldn't get the animated icon to work, i will just remove that sprite state

- type: Sprite
sprite: Clothing/OuterClothing/Hardsuits/paramed.rsi
layers:
- state: icon
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: This line is indented incorrectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Medical Area: Medical department, including Chemistry Changes: Audio Changes: Might require knowledge of audio. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. size/M Denotes a PR that changes 100-999 lines. T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants