-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update validations of hostnames and node names #1
Conversation
why limit length to 48chars? 63 is maximum allowed per level. Some of our nodes have multiple domains assigned to them. This allows them to match which one they were referring. |
Length So our fqdn for an ip_adddress entry is ip_addresses.hostname + '.' + nodes.name_ns + '.ctwug.za.net' I guess you are ignoring name_ns? So allowing dots will work for you? |
thanks for the fqdn, now i understand what your doing. We use ip_addresses.hostname + '.' + dns_zones.name + '.wafn' Which allows us a single node to have many domain names. IE a special "Admin" node has the following domains allocated to it
|
This PR Bigger discussion again To me the best possible model is ip_addresses.hostname + '.' +nodes.name_ns '.' + dns_zones.name. You'd lose duplicate names to some extent, but doesn't seem to be used that often. Note you could also just edit the name_ns field to the "easy version" of a node name. Then we could based on your zone data add zone for wafn and zone for say wafn.co.au or so to make your dns available on the web. Also we "calculate" reverse data based on ip_addresses/nodes data. Our nodes are too many so we can't give each node a /24 to have a separate reverse zone. We share a common address space with other wireless networks in South Africa (allowing peering). We "only" get 172.18 and 172.26. |
Forgot to mention with either model we may need a separate screen to edit the top level dns data. E.g. MX SPF etc. |
agreed "." for now. I'll put further comments in issue #9 |
Update validations of hostnames and node names
err forgot the "." needs doing. If you can add and merge. Then this can be closed. |
Away for couple of days. Will do when I'm back. On Wed, 16 Dec 2015, 06:05 jammin84 [email protected] wrote:
|
This checks the first and last character of node names.
Also adds checking for hostnames.