Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partial fix for #599 add -remoting option #603

Merged
merged 2 commits into from
May 2, 2017
Merged

Partial fix for #599 add -remoting option #603

merged 2 commits into from
May 2, 2017

Conversation

daften
Copy link
Contributor

@daften daften commented Apr 27, 2017

Description

This is a change that allows a -remoting option to be used with jenkins-cli. Full credits go to @p0d0l

Issues Resolved

#599 and #602

Check List

@daften
Copy link
Contributor Author

daften commented Apr 27, 2017

Opened this PR based on the commit by @p0d0l mentioned in #599 (p0d0l/jenkins@d18f599)

@daften
Fix syntax error, space after #
298b1cd 
Signed-off-by: Dieter Blomme <[email protected]>
p0d0l
p0d0l approved these changes Apr 27, 2017
View reviewed changes
Copy link

@p0d0l p0d0l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 ;)

@p0d0l p0d0l mentioned this pull request Apr 27, 2017
Closed
Dispader
Dispader suggested changes Apr 27, 2017
View reviewed changes
Copy link

@Dispader Dispader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good­— are you folks able to test the change?

libraries/_executor.rb
@@ -73,6 +73,8 @@ def execute!(*pieces)
command << options[:jvm_options].to_s if options[:jvm_options]
command << %(-jar "#{options[:cli]}")
command << %(-s #{URI.escape(options[:endpoint])}) if options[:endpoint]
command << %(-"#{options[:protocol]}") if options[:protocol]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to line up the spacing for the new lines, here.

@ehaselwanter
Copy link

@tas50 can you have a look at this?

@arothian
Copy link
Contributor

arothian commented May 1, 2017

For what it's worth, testing this branch against 2.46.2 fixed errors with jenkins_plugin for me.

@jmather
Copy link

jmather commented May 1, 2017

Agreed that this changeset fixes the issues.

@ramereth ramereth mentioned this pull request May 1, 2017
Merged
@daften daften mentioned this pull request May 1, 2017
Closed
@iennae iennae merged commit 494e4ae into sous-chefs:master May 2, 2017
@tknerr
Copy link

tknerr commented Jul 25, 2017

It seems that in current versions of Jenkins 2 (tested with 2.60.1) the default -remoting option does not work anymore, because remoting is turned off by default.:
https://jenkins.io/doc/book/managing/cli/#remoting-connection-mode

You have to explicitly enable remoting under "Manage Jenkins -> Security" or create /var/lib/jenkins/jenkins.CLI.xml with the following content:

    <jenkins.CLI>
      <enabled>true</enabled>
    </jenkins.CLI>

Thanks @darioabashton who led me to this here:
https://stackoverflow.com/a/43891559/2388971

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dispader Dispader Dispader requested changes

@iennae iennae iennae approved these changes

@p0d0l p0d0l p0d0l approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@daften @ehaselwanter @arothian @jmather @tknerr @iennae @Dispader @p0d0l