MRG: refactor calculate_gather_stats to disallow repeated downsampling
#3352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nHash (#3348) Ref: https://github.com/sourmash-bio/sourmash_plugin_branchwater/pull/467/files#r1797783380 Implement `TryInto<KmerMinHash>` for Signature and SigStore to avoid having to clone a (potentially big) minhash sketch.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## latest #3352 +/- ##
=======================================
Coverage 86.42% 86.42%
=======================================
Files 137 137
Lines 16069 16070 +1
Branches 2211 2211
=======================================
+ Hits 13888 13889 +1
Misses 1874 1874
Partials 307 307
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ctb
changed the title
calculate_gather_stats to disallow repeated downsamplingcalculate_gather_stats to disallow repeated downsampling
|
ready for review @luizirber @bluegenes |
luizirber
approved these changes
Oct 15, 2024
ctb
added a commit
that referenced
this pull request
Oct 15, 2024
## [0.16.0] - 2024-10-15 MSRV: 1.65 Changes/additions: * refactor `calculate_gather_stats` to disallow repeated downsampling (#3352) * improve downsampling behavior on `KmerMinHash`; fix `RevIndex::gather` bug around `scaled`. (#3342) * derive Hash for `HashFunctions` (#3344) Updates: * Bump web-sys from 0.3.70 to 0.3.72 (#3354) * Bump tempfile from 3.12.0 to 3.13.0 (#3340)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on the refactoring in #3342 to do less downsampling and also avoids doing intersections twice (per #3196).
Benchmarks in sourmash-bio/sourmash_plugin_branchwater#471 are pretty astonishing...
Fixes #3196