-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MRG: refactor calculate_gather_stats
to disallow repeated downsampling
#3352
Conversation
…nHash (#3348) Ref: https://github.com/sourmash-bio/sourmash_plugin_branchwater/pull/467/files#r1797783380 Implement `TryInto<KmerMinHash>` for Signature and SigStore to avoid having to clone a (potentially big) minhash sketch.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## latest #3352 +/- ##
=======================================
Coverage 86.42% 86.42%
=======================================
Files 137 137
Lines 16069 16070 +1
Branches 2211 2211
=======================================
+ Hits 13888 13889 +1
Misses 1874 1874
Partials 307 307
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
calculate_gather_stats
to disallow repeated downsamplingcalculate_gather_stats
to disallow repeated downsampling
ready for review @luizirber @bluegenes |
## [0.16.0] - 2024-10-15 MSRV: 1.65 Changes/additions: * refactor `calculate_gather_stats` to disallow repeated downsampling (#3352) * improve downsampling behavior on `KmerMinHash`; fix `RevIndex::gather` bug around `scaled`. (#3342) * derive Hash for `HashFunctions` (#3344) Updates: * Bump web-sys from 0.3.70 to 0.3.72 (#3354) * Bump tempfile from 3.12.0 to 3.13.0 (#3340)
This PR builds on the refactoring in #3342 to do less downsampling and also avoids doing intersections twice (per #3196).
Benchmarks in sourmash-bio/sourmash_plugin_branchwater#471 are pretty astonishing...
Fixes #3196