MRG: derive Hash for HashFunctions
#3344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bluegenes
commented
Oct 7, 2024
•
bluegenes
commented
- derive Hash for HashFunctions, so I can use it over in MRG: refactor sketching utilities sourmash_plugin_directsketch#112
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## latest #3344 +/- ##
=======================================
Coverage 86.51% 86.51%
=======================================
Files 137 137
Lines 16046 16046
Branches 2728 2728
=======================================
Hits 13882 13882
Misses 1855 1855
Partials 309 309
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bluegenes
changed the title
HashFunctions
|
@ctb @luizirber ready for review |
ctb
approved these changes
Oct 7, 2024
bluegenes
added a commit
to sourmash-bio/sourmash_plugin_directsketch
that referenced
this pull request
Oct 8, 2024
- refactor for reusability: move all generalized sketch building utils --> `utils/buildutils.rs` - do minor refactoring to use `sourmash::encodings::HashFunctions` for `moltype`, created `Abund` enum. - requires sourmash-bio/sourmash#3344 to use `Hash` for `sourmash::encodings::HashFunctions` Related: - #113
This was referenced Oct 11, 2024
Merged
ctb
added a commit
that referenced
this pull request
Oct 15, 2024
## [0.16.0] - 2024-10-15 MSRV: 1.65 Changes/additions: * refactor `calculate_gather_stats` to disallow repeated downsampling (#3352) * improve downsampling behavior on `KmerMinHash`; fix `RevIndex::gather` bug around `scaled`. (#3342) * derive Hash for `HashFunctions` (#3344) Updates: * Bump web-sys from 0.3.70 to 0.3.72 (#3354) * Bump tempfile from 3.12.0 to 3.13.0 (#3340)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.