Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix clippy lints and MSRV check #2680

Merged
merged 6 commits into from
Jul 18, 2023
Merged

build: fix clippy lints and MSRV check #2680

merged 6 commits into from
Jul 18, 2023

Conversation

luizirber
Copy link
Member

Rust 1.72 beta introduced new clippy lints that are failing on CI, most of them are easy to fix (remove as conversion), but the one changing

pub struct InnerStorage(Arc<Mutex<dyn Storage>>);

to

pub struct InnerStorage(Rc<RwLock<dyn Storage>>);

is a bit more involved. Still need to better evaluate how this will go with threads, but since it is an opaque type we can also change the internal representation without breaking semver.

#2629 introduced an MSRV bump to 1.64 on the test dependencies, added an extra argument --tests in the CI checks to verify test deps too.

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #2680 (c52bd7b) into latest (c7c320f) will increase coverage by 0.02%.
The diff coverage is 23.07%.

@@            Coverage Diff             @@
##           latest    #2680      +/-   ##
==========================================
+ Coverage   85.23%   85.26%   +0.02%     
==========================================
  Files         133      133              
  Lines       15193    15179      -14     
  Branches     2612     2612              
==========================================
- Hits        12950    12942       -8     
+ Misses       1942     1936       -6     
  Partials      301      301              
Flag Coverage Δ
hypothesis-py 25.81% <ø> (ø)
python 92.83% <ø> (ø)
rust 51.64% <23.07%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/src/ffi/cmd/compute.rs 0.00% <0.00%> (ø)
src/core/src/ffi/minhash.rs 0.00% <0.00%> (ø)
src/core/src/ffi/nodegraph.rs 0.00% <0.00%> (ø)
src/core/src/ffi/storage.rs 0.00% <0.00%> (ø)
src/core/src/sketch/minhash.rs 75.15% <0.00%> (-0.16%) ⬇️
src/core/src/storage.rs 70.83% <100.00%> (ø)

... and 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@luizirber luizirber merged commit caccb58 into latest Jul 18, 2023
33 of 34 checks passed
@luizirber luizirber deleted the lirber/rust_1.71 branch July 18, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant