Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase If-Modified-Since tolerance even more #169

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Increase If-Modified-Since tolerance even more #169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/httpserver/request.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ auto ServerRequest::header_if_modified_since(

// Time comparison can be flaky, but adding a bit of tolerance leads
// to more consistent behavior.
return (if_modified_since.value() + std::chrono::milliseconds(1)) <
return (if_modified_since.value() + std::chrono::seconds(1)) <
last_modified;
// If there is an error parsing the `If-Modified-Since` timestamp, don't
// abort, but lean on the safe side: the requested resource has been
Expand Down
Loading