Add setContext notification for cody.serverEndpoint #5918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkukielka
force-pushed
the
pkukielka/add-token-update-notification
branch
from
aa29e17
to
30cabe2
Compare
mkondratek
approved these changes
Oct 17, 2024
vscode/src/services/AuthProvider.ts
Outdated
| 'setContext', | ||
| 'cody.serverEndpoint', | ||
| authStatus.endpoint | ||
| ) | ||
| } catch {} |
There was a problem hiding this comment.
I'd rather have some logging here. Some day we may suffer from unknown and hard to identify problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I've added
cody.serverEndpointcontext variable, which on the clients side is received throughwindow/didChangeContextnotification. We need it on the jetbrains side in few places, e.g. when we are checking if current account is a dotcom account.I think it might be better idea to replace this with a dedicated endpoint, but I'm not sure if
cody.activatedis currently used anywhere?@dominiccooney @sqs WDYT?
Test plan
Full QA with sourcegraph/jetbrains#2382 is needed.
It does not change anything on the Cody side.