feat(provider): new strategy for auth0 #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passport based strategy GH-244
samarpanB
reviewed
Sep 24, 2024
| passReqToCallback?: false | undefined; | ||
| } | ||
| /* eslint-disable-next-line @typescript-eslint/no-explicit-any */ | ||
| export type VerifyCallback = (err?: any, user?: any, info?: any) => void; |
There was a problem hiding this comment.
Isnt this available in passport strategy typings
There was a problem hiding this comment.
no not explicitly
samarpanB
reviewed
Sep 24, 2024
| @@ -120,6 +121,16 @@ export namespace VerifyFunction { | |||
| req?: Request, | |||
| ): Promise<T | null>; | |||
| } | |||
| export interface Auth0Fn<T = IAuthUser> extends GenericAuthFn<T> { | |||
There was a problem hiding this comment.
We create interface for each strategy based on its verify function type
samarpanB
reviewed
Sep 24, 2024
sonar fix GH-244
|
|
🎉 This PR is included in version 12.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
passport based strategy
GH-244
Description
Added a new passport based strategy for auth0 authentication.
Fixes #244
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Used this package in sourceloop based authentication service
Checklist: