Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visualisations for the new Scheme Implementation #3075

Merged
merged 18 commits into from
Jan 22, 2025

Conversation

s-kybound
Copy link
Member

@s-kybound s-kybound commented Nov 13, 2024

Description

This PR adds a continuation representation as well as support for the enhanced CSE(T) machine that can now natively support scheme items.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Checklist

  • I have tested this code
  • I have updated the documentation

@s-kybound s-kybound marked this pull request as ready for review November 13, 2024 12:08
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12900477202

Details

  • 19 of 96 (19.79%) changed or added relevant lines in 11 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 31.196%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/features/cseMachine/components/arrows/Arrow.tsx 0 1 0.0%
src/features/cseMachine/CseMachineLayout.tsx 3 5 60.0%
src/features/cseMachine/components/ControlStack.tsx 1 4 25.0%
src/features/cseMachine/utils/scheme.ts 2 5 40.0%
src/features/cseMachine/CseMachineUtils.ts 8 12 66.67%
src/features/cseMachine/CseMachineAnimation.tsx 0 19 0.0%
src/features/cseMachine/components/values/ContValue.tsx 0 45 0.0%
Files with Coverage Reduction New Missed Lines %
src/features/cseMachine/components/ControlStack.tsx 1 70.21%
Totals Coverage Status
Change from base Build 12841946346: -0.1%
Covered Lines: 4842
Relevant Lines: 14646

💛 - Coveralls

Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@martin-henz martin-henz merged commit c1c784d into source-academy:master Jan 22, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants