Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sos] Set a User Agent for s3 based uploads #3823

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TrevorBenson
Copy link
Member

@TrevorBenson TrevorBenson commented Oct 25, 2024

Signed-off-by: Trevor Benson [email protected]


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

I thought it might be best not to use the bare word config or Config for just the s3 uploader, so I adjusted them. I'm open to any suggestions, like making them similar (i.e. Boto3Config or botocore_config), or any preferred style suggested.

@TrevorBenson TrevorBenson force-pushed the sos-trevorbenson-set-s3-useragent branch from 4352c29 to 78899d6 Compare October 25, 2024 23:19
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3823
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@TrevorBenson TrevorBenson force-pushed the sos-trevorbenson-set-s3-useragent branch from 78899d6 to 8214a1a Compare October 25, 2024 23:41
@arif-ali
Copy link
Member

arif-ali commented Nov 1, 2024

/packit rebuild-failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants