Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[networking] Capture /etc/nmstate folder #3791

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jcastill
Copy link
Member

Capture configuration files, .yml and .applied
files in /etc/nmstate folder.


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3791
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@pmoravec
Copy link
Contributor

You state "capture .yml and applied conf files, but the patch grabs whole directory - is that intentional?

@jcastill
Copy link
Member Author

You state "capture .yml and applied conf files, but the patch grabs whole directory - is that intentional?

Yes, it was an attempt to explain what kind of files will be in there and what to expect will be collected.

@jcastill jcastill marked this pull request as draft September 26, 2024 15:15
@jcastill jcastill force-pushed the jcastillo-capture-etc-nmstate-folder branch from 8850bd4 to 98d2049 Compare October 7, 2024 14:30
Capture configuration files, .yml and .applied
files in /etc/nmstate folder.

Signed-off-by: Jose Castillo <[email protected]>
@jcastill jcastill force-pushed the jcastillo-capture-etc-nmstate-folder branch from 98d2049 to e7fd788 Compare October 11, 2024 07:35
@jcastill jcastill marked this pull request as ready for review October 11, 2024 07:48
@jcastill
Copy link
Member Author

Finally, final version is here. Took a bit longer because I was gathering with engineering what keywords we need to obfuscate, but the list is complete now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants