Module/docker

[akarzim]

Proposed Changes on Docker aliases

Added

• new alias to send kill -s HUP signal to a running container
• new aliases to fetch and follow the logs of a container
• new alias to pull all tagged images

Fixed

• force terminal geometry on dkE alias

[indrajitr]

Mostly looks good. @akarzim, would you consider the suggestions inlined?

[belak]

Why was this modified? I understand what it does, but this shouldn't be needed.

[akarzim]

My coworkers and me often encounter weird behaviour on interactive terminal, lines wrap at 80 characters and overlaps themselves. This workaround fix this issue.

[belak]

Does it do the same thing when using the docker-compose binds below? Would it be worth adding there as well?

[akarzim]

docker-compose exec doesn't allow interactive terminal, but docker container exec does. As well as docker run and docker container run. I'll add the environment variables there too.

[belak]

I think you're mistaken. I just double checked and docker-compose exec is interactive and has a pseudo-tty allocated by default. It would be nice to have those variables there as well.

Otherwise, it looks good to me!

~ % cat docker-compose.yml
version: '2'
services:
  mysql:
    image: mysql:5.7
    ports:
     - "3306:3306"
    environment:
      MYSQL_ROOT_PASSWORD: "secret"
      MYSQL_DATABASE: "homestead"
      MYSQL_USER: "homestead"
      MYSQL_PASSWORD: "secret"
    volumes:
     - mysqldata:/var/lib/mysql
volumes:
  mysqldata:
~ % docker-compose up -d
belak_mysql_1 is up-to-date
~ % docker-compose exec mysql bash
root@3012bf149158:/# ls
bin  boot  dev	docker-entrypoint-initdb.d  entrypoint.sh  etc	home  lib  lib64  media  mnt  opt  proc  root  run  sbin  srv  sys  tmp  usr  var
root@3012bf149158:/# exit

[akarzim]

You're totally right ! Though, you may need to include the following lines in your docker-compose.yml to enable interactive mode in some environments:

stdin_open: true
tty: true

The first corresponds to -i in docker run and the second to -t.

source: https://stackoverflow.com/questions/36249744/interactive-shell-using-docker-compose#39150040