Add Dockerfile #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| RUN gem install --no-document etcenv | ||
|
|
||
| RUN groupadd -g 500 core && useradd -u 500 -g 500 core |
There was a problem hiding this comment.
Ah, right, had a specific use case for that. But that's not even the case anymore. I'll remove that commit.
|
Sorry for late reply! |
| @@ -0,0 +1,5 @@ | |||
| FROM ruby | |||
|
|
|||
| RUN gem install --no-document etcenv | |||
There was a problem hiding this comment.
RUN mkdir /app
WORKDIR /app
ADD . /app
RUN bundle install
ENTRYPOINT ["bundle", "exec", "etcenv"]
There was a problem hiding this comment.
Right, building from source is even better ;)
But bundler is not needed here. I changed it to use the normal gem build procedure now. Just take whichever you like best..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, please consider adding an automated build to the Docker registry hub afterwards. This makes it easier to run e.g. on CoreOS.
Thanks for your work!