Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/#940 #944

Merged
merged 27 commits into from
Nov 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
b26fb37
feat: 곡동λͺ¨μž„μž₯ κΈ°λ³Έ ν‹€ κ΅¬ν˜„
ocahs9 Oct 27, 2024
73ad3a2
feat: button에 νƒ€μž… μ§€μ •ν•΄μ€˜μ„œ μ›μΉ˜ μ•ŠλŠ” submit μ•ˆλ˜λ„λ‘ λ°©μ§€ν•˜κΈ°
ocahs9 Oct 27, 2024
f8906a7
feat: λ©˜μ…˜μ„ ν¬ν•¨ν•œ input ν‹€ μ™„μ„±(μ™„μ „νžˆ λ””μžμΈ λ˜‘κ°™μ΄ κ΅¬ν˜„μ€ x)
ocahs9 Oct 28, 2024
67c3dbf
fix: +λ²„νŠΌ μ•žμ— κ³ μ •
ocahs9 Oct 28, 2024
d7d2fa7
design: inputμ°½ μ—΄λ €μžˆμ„ λ•Œ λ²„νŠΌ λ°μ•„μ§€λŠ” 것 μœ μ§€
ocahs9 Oct 28, 2024
27d7a6b
feat: λͺ¨μž„ κ°œμ„€ - 곡동 λͺ¨μž„μž₯ μΆ”κ°€ λ·°,κΈ°λŠ₯ κ΅¬ν˜„ μ™„λ£Œ
ocahs9 Oct 29, 2024
084b75e
design: ν”Όκ·Έλ§ˆμƒμ—μ„œλŠ” 8px둜 λ˜μ–΄μžˆμ–΄μ„œ μˆ˜μ •
ocahs9 Oct 29, 2024
e3c86d0
design: mobile λ°˜μ‘ν˜• λ””μžμΈ κ΅¬ν˜„
ocahs9 Oct 29, 2024
b793d91
fix: coLeader.map is not a function 버그 ν•΄κ²°
ocahs9 Oct 29, 2024
af213c0
feat: λͺ¨λ°”일 λ©˜μ…˜ λ°”ν…€μ‹œνŠΈ κ΅¬ν˜„
ocahs9 Oct 29, 2024
f0a3a96
design: λͺ¨μž„μž₯ ν”„λ‘œν•„ λ””μžμΈ λ³€κ²½
ocahs9 Oct 29, 2024
2a64b65
design: λΆˆν•„μš”ν•œ margin 제거
ocahs9 Oct 29, 2024
10dae42
chore: 이해λ₯Ό λ•λŠ” 주석 첨가, λΆˆν•„μš”ν•œ μ½˜μ†” 제거
ocahs9 Oct 29, 2024
a62a4ce
update: API 버전 μ΅œμ‹ ν™”
borimong Oct 30, 2024
c381332
fix: μ›Ήλ·°-ν”Όλ“œ μž‘μ„± λͺ¨λ‹¬ λ¬΄ν•œ λ Œλ”λ§ 이슈
borimong Oct 30, 2024
7ae607e
update: λ©˜μ…˜ μœ μ € 리슀트 쑰회 API μ΅œμ‹ ν™”
borimong Oct 30, 2024
f1fc140
feat: isCoLeader λ³€μˆ˜ μΆ”κ°€
borimong Oct 30, 2024
9b05b4b
Merge branch 'feat/#936' of https://github.com/sopt-makers/sopt-crew-…
borimong Oct 30, 2024
8533976
update: API μ΅œμ‹ ν™” (approvedCount)
borimong Oct 31, 2024
6104476
feat: λ©˜μ…˜ νƒ€μž…μ— userId μΆ”κ°€
borimong Oct 31, 2024
f6246b5
feat: isCoLeader 선택적 νƒ€μž… μ •μ˜
borimong Oct 31, 2024
cb183e0
feat: formData에 coLeaderUserIds μΆ”κ°€
borimong Oct 31, 2024
4363efe
feat: ProfileAnchor μ»΄ν¬λ„ŒνŠΈ 뢄리
borimong Nov 3, 2024
096dd95
feat: λͺ¨μž„ 상세 νŽ˜μ΄μ§€μ— ProfileAnchor 적용
borimong Nov 3, 2024
ae0c43e
feat: λͺ¨μž„ μˆ˜μ •μ— 곡동 λͺ¨μž„μž₯ 데이터 좜λ ₯
borimong Nov 3, 2024
58a102f
feat: λͺ¨μž„ μˆ˜μ • μ‹œ λ‹€μ΄μ–Όλ‘œκ·Έ μ›Œλ”© λ³€κ²½
borimong Nov 3, 2024
61a6989
Merge branch 'develop' of https://github.com/sopt-makers/sopt-crew-fr…
borimong Nov 3, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pages/edit/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ const EditPage = () => {
joinableParts,
canJoinOnlyActiveGeneration: formData?.canJoinOnlyActiveGeneration,
note: formData?.note ?? '',
coLeader: formData?.coMeetingLeaders,
},
});
}
Expand Down
161 changes: 110 additions & 51 deletions src/__generated__/schema2.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions src/api/API_LEGACY/meeting/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,7 @@ const serializeFormData = (formData: FormType) => {
//targetDesc: formData.detail.targetDesc,
note: formData.detail.note,
detail: undefined,
coLeaderUserIds: formData.detail.coLeader?.map(user => user.userId),
};
return data;
};
Expand Down
3 changes: 2 additions & 1 deletion src/api/user/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ export interface UserResponse {
export type ApplicationStatusType = 'WAITING' | 'APPROVE' | 'REJECT';

export const getMentionUsers = async () => {
const { data } = await api.get('/user/v2/mention');
//νƒ€μž… μ§€μ •ν•˜μ§€ μ•Šμ€ 이유: Suggestion의 id, display λ₯Ό μ‚¬μš©ν•΄μ•Όν•˜κΈ° λ•Œλ¬Έ
const { data } = await api.get('/user/v2');
return data;
};
1 change: 1 addition & 0 deletions src/components/feed/Mention/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import { MentionContext } from './MentionContext';
interface mentionableDataType {
id: number;
display: string;
userId: number;
orgId: number;
userName: string;
recentPart: string;
Expand Down
10 changes: 6 additions & 4 deletions src/components/feed/Modal/FeedFormPresentation.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,13 @@ function FeedFormPresentation({
const [remainingHeight, setRemainingHeight] = useState(100);
const [selectedMeeting, setSelectedMeeting] = useState<GroupInfo | undefined>(undefined);
const [isMobileDevice, setIsMobileDevice] = useState(false);
const userAgent = navigator.userAgent;

if (/android/i.test(userAgent) || /iPad|iPhone|iPod/.test(userAgent)) {
setIsMobileDevice(true);
}
useEffect(() => {
const userAgent = navigator.userAgent;
if (/android/i.test(userAgent) || /iPad|iPhone|iPod/.test(userAgent)) {
setIsMobileDevice(true);
}
}, []);

const handleWindowResize = () => {
setTextareaHeightChangeFlag(flag => !flag);
Expand Down
10 changes: 7 additions & 3 deletions src/components/form/Presentation/CoLeader/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,12 @@ interface mentionableDataType {
id: number;
display: string;
orgId: number;
userId: number;
userName: string;
recentPart: string;
recentGeneration: number;
profileImageUrl: string;
userprofileImage?: string;
}

const CoLeader = ({ value: coLeaders = [], onChange, error }: CoLeaderFieldProps) => {
Expand Down Expand Up @@ -138,11 +140,13 @@ const CoLeader = ({ value: coLeaders = [], onChange, error }: CoLeaderFieldProps

{/*μΆ”κ°€λœ 곡동 λͺ¨μž„μž₯ ν”„λ‘œν•„ λ Œλ”λ§ */}
<LeadersWrapper>
{coLeaders.map((leader, idx) => (
<Leader key={leader.id}>
{coLeaders?.map((leader, idx) => (
<Leader key={leader?.userId}>
<SProfile>
{leader.profileImageUrl ? (
{leader?.profileImageUrl ? (
<img src={leader.profileImageUrl} alt={leader.userName} />
) : leader?.userprofileImage ? (
<img src={leader?.userprofileImage} alt={leader.userName} />
) : (
<StyledProfileDefaultIcon />
)}
Expand Down
5 changes: 3 additions & 2 deletions src/components/form/Presentation/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ function Presentation({
const { open } = useDialog();
const [isSoptScheduleOpen, setIsSoptScheduleOpen] = useState(false);
const soptScheduleRef = useRef<HTMLDivElement | null>(null);
const isEdit = router.asPath.includes('/edit');

const schedule: React.ReactNode = (
<>
Expand Down Expand Up @@ -152,12 +153,12 @@ function Presentation({
};

const dialogOption: DialogOptionType = {
title: 'λͺ¨μž„을 κ°œμ„€ν•˜μ‹œκ² μŠ΅λ‹ˆκΉŒ?',
title: `λͺ¨μž„을 ${isEdit ? 'μˆ˜μ •' : 'κ°œμ„€'}ν•˜μ‹œκ² μŠ΅λ‹ˆκΉŒ?`,
description: 'λͺ¨μž„에 λŒ€ν•œ μ„€λͺ…이 μΆ©λΆ„νžˆ μž‘μ„±λ˜μ—ˆλŠ”μ§€ 확인해 μ£Όμ„Έμš”',
type: 'default',
typeOptions: {
cancelButtonText: 'μ·¨μ†Œ',
approveButtonText: 'κ°œμ„€ν•˜κΈ°',
approveButtonText: `${isEdit ? 'μˆ˜μ •' : 'κ°œμ„€'}ν•˜κΈ°`,
buttonFunction: () => {
if (formRef.current) {
formRef.current.requestSubmit();
Expand Down
1 change: 1 addition & 0 deletions src/components/form/SearchMention/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ interface mentionableDataType {
id: number;
display: string;
orgId: number;
userId: number;
userName: string;
recentPart: string;
recentGeneration: number;
Expand Down
Loading
Loading