Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input 높이 및 모집 대상 chip 변경 #924

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Input 높이 및 모집 대상 chip 변경 #924

merged 3 commits into from
Oct 10, 2024

Conversation

j-nary
Copy link
Member

@j-nary j-nary commented Oct 10, 2024

🚩 관련 이슈

📋 작업 내용

  • Input 높이 조정
  • 모집 대상 Chip 변경

📌 PR Point

  • 무슨 이유로 어떻게 코드를 변경했는지
  • 어떤 위험이나 우려가 발견되었는지
  • 어떤 부분에 리뷰어가 집중해야 하는지
  • 개발하면서 어떤 점이 궁금했는지

📸 스크린샷

image

@j-nary j-nary self-assigned this Oct 10, 2024
@height Height
Copy link

height bot commented Oct 10, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@j-nary j-nary merged commit 02ee18e into develop Oct 10, 2024
2 checks passed
ocahs9 added a commit that referenced this pull request Oct 13, 2024
@ocahs9
Revert "Input 높이 및 모집 대상 chip 변경 (#924)"
ec44c82 
This reverts commit 02ee18e.
ocahs9 added a commit that referenced this pull request Oct 13, 2024
@ocahs9
Chip 부분만 revert하고 변경사항들은 반영 (#929)
b0f67c4 
* Revert "모임 개설 대상 파트 Chip 으로 변경 (#914)"

This reverts commit d185a08.

* Revert "Input 높이 및 모집 대상 chip 변경 (#924)"

This reverts commit 02ee18e.
@ocahs9 ocahs9 mentioned this pull request Oct 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borimong borimong Awaiting requested review from borimong borimong is a code owner

@ocahs9 ocahs9 Awaiting requested review from ocahs9 ocahs9 is a code owner

Assignees

@j-nary j-nary

Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

모임 개설 2차 디자인 QA
1 participant
@j-nary