모임 개설 대상 파트 Chip 으로 변경 #914
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| import { Option } from '@components/form/Select/OptionItem'; | ||
| import { parts } from '@data/options'; | ||
| import { Chip } from '@sopt-makers/ui'; | ||
| import { useState, useEffect } from 'react'; | ||
|
|
||
| interface JoinablePartsFieldProps { | ||
| value: Option[]; | ||
| onChange: (newSelectedParts: Option[]) => void; | ||
| } | ||
|
|
||
| const JoinablePartsField = ({ value, onChange }: JoinablePartsFieldProps) => { | ||
| const [selectedParts, setSelectedParts] = useState<Option[]>([]); | ||
|
|
||
| useEffect(() => { | ||
| if (Array.isArray(value)) { | ||
| setSelectedParts(value); // value prop이 변경되면 상태 동기화 | ||
| } | ||
| }, [value]); | ||
|
|
||
| const handleClick = (selectedOption: Option) => { | ||
| let updatedParts = [...selectedParts]; | ||
|
|
||
| // 'all' 옵션을 클릭했을 때 처리 | ||
| if (selectedOption.value === 'all') { | ||
| if (selectedParts.some(part => part.value === 'all')) { | ||
| // 전체 옵션이 이미 선택되어 있으면 해제 | ||
| updatedParts = []; | ||
| } else { | ||
| // 전체 옵션을 선택하면 모든 부분을 선택 | ||
| updatedParts = parts; | ||
| } | ||
| } else { | ||
| // 개별 옵션을 선택할 때 | ||
| if (selectedParts.some(part => part.value === selectedOption.value)) { | ||
| // 이미 선택된 항목이면 해제 | ||
| updatedParts = updatedParts.filter(part => part.value !== selectedOption.value); | ||
| } else { | ||
| // 선택되지 않은 항목이면 추가 | ||
| updatedParts.push(selectedOption); | ||
| } | ||
|
|
||
| // 개별 옵션 해제 시 전체 옵션도 해제 | ||
| if (updatedParts.some(part => part.value === 'all') && updatedParts.length < parts.length) { | ||
| updatedParts = updatedParts.filter(part => part.value !== 'all'); | ||
| } | ||
|
|
||
| // 모든 개별 파트가 선택되었으면 'all' 옵션도 활성화 | ||
| if (updatedParts.length === parts.length - 1) { | ||
| updatedParts.push(parts[0]); | ||
| } | ||
| } | ||
|
|
||
| setSelectedParts(updatedParts); | ||
| onChange(updatedParts); // 선택된 파트의 value만 전달 | ||
| }; | ||
|
There was a problem hiding this comment. 코드가 조금 verbose 한 면이 있어서, 리팩토링을 해보면 좋을 것 같아! 지금 진이는, value 라는 사용자 입력 값을 useEffect 를 이용해서 지켜보면서, setState 를 해주고 있는데, 관점을 바꿔서 사용자 이벤트를 기반으로 리팩토링해보면 좋지 않을까 하는 생각이야~ There was a problem hiding this comment. 좋은 피드백 고마오 !! 코드리뷰 반영했는데 한 번 확인해줄 수 있어 ? There was a problem hiding this comment. 훨씬 깔끔해진 거 같애! 충돌만 잡고 머지해보자~! |
||
|
|
||
| return ( | ||
| <> | ||
| {parts.map(part => ( | ||
| <Chip | ||
| active={selectedParts.some(selected => selected.value === part.value)} | ||
| onClick={() => handleClick(part)} | ||
| key={part.value} | ||
| style={{ width: '80px' }} | ||
| > | ||
| {part.label} | ||
| </Chip> | ||
| ))} | ||
| </> | ||
| ); | ||
| }; | ||
|
|
||
| export default JoinablePartsField; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
콘솔 제거 고마워~!