Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

모임개설API 리팩토링 #900

Merged
merged 10 commits into from
Oct 1, 2024
Merged

모임개설API 리팩토링 #900

merged 10 commits into from
Oct 1, 2024

Conversation

j-nary
Copy link
Member

@j-nary j-nary commented Oct 1, 2024

🚩 관련 이슈

📋 작업 내용

  • 모임개설API 리팩토링

📌 PR Point

  • 무슨 이유로 어떻게 코드를 변경했는지
  • 어떤 위험이나 우려가 발견되었는지
  • 어떤 부분에 리뷰어가 집중해야 하는지
  • 개발하면서 어떤 점이 궁금했는지

📸 스크린샷

image

@j-nary j-nary self-assigned this Oct 1, 2024
@j-nary j-nary requested review from borimong and ocahs9 as code owners October 1, 2024 15:14
@height Height
Copy link

height bot commented Oct 1, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@j-nary j-nary merged commit 095e89d into develop Oct 1, 2024
1 check passed
j-nary added a commit that referenced this pull request Oct 3, 2024
@j-nary @borimong
모임상세조회 API 리팩토링
3de2624 
* 모임개설API 리팩토링 (#900)

* refactor: 모임 상세 조회 API 마이그레이션

* Delete src/api/API_LEGACY/meeting/index.ts

* fix: prettier 오류 해결

* fix: Data 구조 분해 및 타입 지정

* fix: ESLint 오류 해결

* refactor: 데이터 구조 변경

* refactor: getMeeting v2 마이그레이션

* fix: mStartDate, mEndDate 속성 없음 이슈 해결

* fix: 타입 업데이트

* fix: 타입 업데이트

* getmStartDate -> mStartDate (#901)

* refactor: 모임 상세 조회 API 마이그레이션

* Delete src/api/API_LEGACY/meeting/index.ts

* fix: prettier 오류 해결

* fix: Data 구조 분해 및 타입 지정

* fix: ESLint 오류 해결

* refactor: 데이터 구조 변경

* refactor: getMeeting v2 마이그레이션

* fix: mStartDate, mEndDate 속성 없음 이슈 해결

* fix: 타입 업데이트

* fix: 타입 업데이트

* fix: 필드명 업데이트

* test: 공백 지우기

* Revert "getmStartDate -> mStartDate (#901)" (#902)

This reverts commit 476107b.

* feat: 모임상세조회 API

---------

Co-authored-by: Hyeonsu Kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borimong borimong Awaiting requested review from borimong borimong is a code owner

@ocahs9 ocahs9 Awaiting requested review from ocahs9 ocahs9 is a code owner

Assignees

@j-nary j-nary

Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

모임 상세 조회 API 마이그레이션
1 participant
@j-nary