-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
피드 상세 뷰에 해당 모임 피드 리스트 추가 #602
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with Cloudflare Pages
|
eunsukimme
temporarily deployed
to
development
December 2, 2023 16:14 — with
GitHub Actions
Inactive
eunsukimme
temporarily deployed
to
development
December 5, 2023 15:31 — with
GitHub Actions
Inactive
eunsukimme
temporarily deployed
to
development
December 9, 2023 11:30 — with
GitHub Actions
Inactive
eunsukimme
requested review from
100Gyeon,
borimong and
na-reum
as code owners
December 9, 2023 11:42
eunsukimme
temporarily deployed
to
development
December 9, 2023 12:22 — with
GitHub Actions
Inactive
eunsukimme
temporarily deployed
to
development
December 9, 2023 12:30 — with
GitHub Actions
Inactive
100Gyeon
approved these changes
Dec 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀🚀🚀🚀🚀
pages/post/index.tsx
Outdated
const handleLikeClick = (postId: number) => (e: React.MouseEvent<HTMLButtonElement>) => { | ||
e.preventDefault(); | ||
mutateLike(postId); | ||
// TODO: ampli logging 필요? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* feat: 댓글 입력 placeholder 변경 * feat: 좋아요 영역 hover 처리 * feat: 댓글 수 표시 영역을 버튼으로 spec 변경, 댓글 버튼 클릭 시 댓글 textarea 포커스 * feat: 더보기 버튼 왼쪽에 공유 버튼 추가 (클릭 시 토스트 메시지 등장) * chore: color 및 크기 수정 * feat: hover 시 버튼 처리 * chore: textarea focus 시 처리 * feat: 모임 정보 안내 버튼 추가 * feat: 모임 정보 안내 버튼 안에 아이콘 추가 * feat: 모임 소개 말줄임 처리 * refactor: 코드 리뷰 반영 * feat: 댓글 입력 부분 디자인 수정사항 반영
eunsukimme
temporarily deployed
to
development
December 9, 2023 15:00 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚩 관련 이슈
📋 작업 내용
meetingid
) props 추가📌 PR Point
meetingId
를 필요로하는데 이게router.query.id
와 커풀링 되어 있어요. 그런데 게시글 상세페이지는router.query.id
가 모임의 id가 아닌 게시글의 id이기 때문에 다르게 처리해줘야 했어요. 그래서 props로 meetingId를 받을 수 있도록 수정했어요.📸 스크린샷