-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update doc to include IS-10 #364
Conversation
@lo-simon Are the settings.h changes meant to be in this PR? They look related to IS-12, not IS-10. Edit: Apart from the actual change mentioned in the commit comment "highest_pri and lowest_pri are used in Node only", of course!! |
Thanks, @garethsb, you are right, I must be using the IS-12 branch while doing the document update, I will fix it now. |
When Authorization was implemented, |
Documents/Dependencies.md
Outdated
These [instructions](Getting-Started.md) explain how to build nmos-cpp itself, run the test suite, and try out the registry and node applications. | ||
These [instructions](Getting-Started.md) explain how to build nmos-cpp itself, run the test suite, and try out the registry and node applications. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's changed here? 🤔
Co-authored-by: Gareth Sylvester-Bradley <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This diagram still shows the Device Code Flow grant type in it which should perhaps be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well spotted, I will remove Device Code Flow grant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit confused by the Authorization Process box at the bottom of the diagram. This contains a Client Credentials Flow box which suggests this is process is infinitely recursive!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am trying to show once the connection is broken between Auth server & the Node, Node will start over again to fetch Auth server metadata.... and Client Credentials flow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to the Client Credentials diagram, the Authorization Process box at the bottom of the diagram contains an Authorization Code Flow box suggesting an infinite recursion :|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what the "Is required to access protected API?" diamond is asking. Also on "No" it enters the "do authorization_operation" loop which only seems to exit on Failed - is that right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's a separate process (like the "start authorization code flow" box) should it perhaps be "start authorization_operation loop"? (same applies I guess to the authorization_operation box at the bottom of the diagram)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Update documents and diagrams to include
IS-10
implementation.