[syncd] Move logSet logGet under mutex to prevent race condition #1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@kcudnik Can you raise a PR to 202405 to address conflict? |
after this will pass |
|
@kcudnik Would you please elaborate on what issue you saw without the fix? We saw an issue which I'm not sure whether it's the same |
Saw the referenced ticket:) |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
arm fail becaue of syslog pipeline, not related to PR |
|
/azp run Azure.sonic-sairedis |
|
Azure Pipelines successfully started running 1 pipeline(s). |
abdosi
approved these changes
Jan 25, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@kcudnik : can you create PR for 202405 ? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-sairedis |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: sonic-net/sonic-buildimage#21180
Mutex is added to protect m_logLevelMap when doing logSet from multiple thread