-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Virtium SSD which doesn't support SmartCMD, to use only smartctl #522
Change Virtium SSD which doesn't support SmartCMD, to use only smartctl #522
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azpw run Azure.sonic-platform-common |
/AzurePipelines run Azure.sonic-platform-common |
Azure Pipelines successfully started running 1 pipeline(s). |
@wangxin A kind reminder, can you please handle the failure which is caused by moving from Bullseye to Bookworm? |
/azpw run Azure.sonic-platform-common |
/AzurePipelines run Azure.sonic-platform-common |
Azure Pipelines successfully started running 1 pipeline(s). |
@prgeor can you please take a look? |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
3604c4d
to
4d16199
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
4d16199
to
46f1905
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@noaOrMlnx could you also fix output before/after change in the PR description to have uniform output format? One has |
@assrinivasan Done |
@bingwang-ms can you please help to check that? |
@bingwang-ms @prgeor kind reminder. can you please help to merge? |
Cherry-pick PR to 202411: #531 |
Description
Add support for Virtium SSD which can't use SmartCMD - to use only smartctl (using generic ssd info parser).
Motivation and Context
There are Virtium SSDs which can't receive SSD info from 'SmartCMD', and must use 'smartctl' command.
For those SSDs, after calling the generic ssd parser, the function is finished and the specific vendor parser won't be called.
How Has This Been Tested?
I tested it manually with a special Virtium SSD which doesn't support SmartCMD
Additional Information (Optional)
output after the change:
root@sonic:/home/admin# show platform ssdhealth
Disk Type : NVME
Device Model : Virtium VTPM24CEXI080-BM110006
Health : 100.0%
Temperature : 52.0C
output before the change:
root@sonic:/home/admin# show platform ssdhealth
[Error] Cannot read SMART information on device /dev/nvme0n1
Disk Type : NVME
Device Model : Virtium VTPM24CEXI080-BM110006
Health : N/A
Temperature : 51.0C