Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the route check monit error seen when test_route_consistency.py #16586

Open
wants to merge 59 commits into
base: master
Choose a base branch
from

Conversation

abdosi
Copy link
Contributor

@abdosi abdosi commented Jan 20, 2025

What/Why I did:
Fix the route check monit error seen when test_route_consistency.py

How I did:

  1. Explicit route_check at start/end of test case and restart monit routeCheck to remove fall positive monit error logs

abdosi and others added 30 commits February 5, 2021 17:00
as we are seding packet > 4k in some cases where there is HBM involved
to fill the buffer faster.

Signed-off-by: Abhishek Dosi <[email protected]>
abdosi and others added 23 commits June 5, 2024 06:49
Signed-off-by: Abhishek Dosi <[email protected]>
… to APP DB modify route consistency

test to make sure all upstream LC;s have same route and all downstream LC's have same route.

Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
and to test route-map functionality is working fine as expected.

Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
…ER_ATTR_EGRESS and

SAI_LAG_MEMBER_ATTR_INGRESS value of enable/disable

On disable:
1. Control packets to/from should not be processed (BGP down)
2. Data packets from/to CPU not be processed (ping to IP interface should faild)
3. Data packets across ports not to be processed  (ping to another peer ip should fail)

Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@abdosi abdosi requested a review from yejianquan January 20, 2025 04:01
@abdosi
Copy link
Contributor Author

abdosi commented Jan 20, 2025

@yejianquan / @cyw233 @vperumal for viz.

@cyw233
Copy link
Contributor

cyw233 commented Jan 20, 2025

Hey @abdosi, seems like the flaky8 check failed with following error:

flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/route/test_route_consistency.py:19:1: E302 expected 2 blank lines, found 1
tests/route/test_route_consistency.py:41:1: E302 expected 2 blank lines, found 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants