Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snappi test: verify pfcwd not triggered in absence of traffic #16552

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sreejithsreekumaran
Copy link
Contributor

@sreejithsreekumaran sreejithsreekumaran commented Jan 16, 2025

Description of PR

Added support to check no PFCWD storm is detected when no traffic is flowing.

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

How did you do it?

Modified existing testcase.

Added a new flag to the test fixture to have_data and/or trigger_pfcwd
When the trigger_pfcwd is true and have_data is False, it is a no traffic case
In this case, send only PFC storm

How did you verify/test it?

Ran snappi test

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sreejithsreekumaran sreejithsreekumaran marked this pull request as draft January 16, 2025 12:22
@sreejithsreekumaran sreejithsreekumaran changed the title test pfcwd with no traffic support in snappi Support for test of pfcwd with no traffic in snappi Jan 23, 2025
@sreejithsreekumaran sreejithsreekumaran marked this pull request as ready for review January 23, 2025 15:55
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sreejithsreekumaran sreejithsreekumaran changed the title Support for test of pfcwd with no traffic in snappi snappi test: verify pfcwd not triggered in absence of traffic Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants