Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reopen #14023 - bgp-session-flap: [T2] Modify tests to run on duts having vsonic neighbors #16537

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sanjair-git
Copy link
Contributor

Description of PR

Summary:
Fixes # (issue)

Reopening the changes of #14023 as a new PR

  • This PR fixes issue for test 'test_bgp_session_flap.py', when the test is run on T2 dut, connected to vsonic neighbors.
  • Currently the test runs fine on dut connected to ceos neighbors.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

  • When the test_bgp_session_flap is run on T2 duts connected to vsonic neighbors, the following error occurs and the test fails.
    filename = '/data/tests/bgp/test_bgp_session_flap.py' function_name = 'setup' index = 0 line_number = 96 lines = [' nbrhosts[tor1]["host"].eos_command(commands=["show run | section bgp"])))\n'] module_args = [] module_async = False module_ignore_errors = False previous_frame = <frame at 0x3eb6080, file '/data/tests/bgp/test_bgp_session_flap.py', line 96, code setup> res = {'failed': True, 'msg': 'Connection type ssh is not valid for this module', '_ansible_no_log': None, 'changed': False} self = <SonicHost VM2902> verbose = True common/devices/base.py:131: RunAnsibleModuleFail</error>

  • Fix the above error, by adding vsonic support to the test.

How did you do it?

  • Make sure, test handles dut connected to both ceos and vsonic neighbors.

How did you verify/test it?

  • Ran all the above-mentioned test cases on a T2 chassis and made sure tests passed with expected behavior.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

image

image

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants