[ip/test_mgmt_ipv6_only]: Refactor to properly cleanup on failure #16442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ipv6 mgmt only tests can fail in setup, after config has been modified, leading to the teardown to not be run. Refactor the test to split backing up and restoring the config into another fixture, such that failures in setting the mgmt IPs wont nuke the testbed. Also refactor some other aspects to remove linter bypasses Signed-off-by: Liam Kearney <[email protected]>
liamkearney-msft
force-pushed
the
pub-dev/ipv6-refactor
branch
from
1fa636d to
43def98
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liamkearney-msft
force-pushed
the
pub-dev/ipv6-refactor
branch
from
09449ef to
7494644
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Liam Kearney <[email protected]>
liamkearney-msft
force-pushed
the
pub-dev/ipv6-refactor
branch
from
7494644 to
1079df2
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Javier-Tan
reviewed
Jan 20, 2025
| @@ -55,10 +53,8 @@ def check_ntp_status(host): | |||
| return True | |||
|
|
|||
|
|
|||
| def run_ntp(duthosts, rand_one_dut_hostname, setup_ntp): | |||
| def run_ntp(duthost): | |||
There was a problem hiding this comment.
Just to confirm we're removing setup_ntp here because the fixtures are/should be called locally and not used in this function?
There was a problem hiding this comment.
yeah, in this case its redundant - the fixture is not called / used here as this is not a test function. The fixtures are only invoked by the test_xxx functions / or other fixtures
|
@arlakshm @yejianquan pls review when you get the chance, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
ipv6 mgmt only tests can fail in setup, after config has been modified, leading to the teardown to not be run, and the duts to be left in an unreachable state. Refactor the test to split backing up and restoring the config into an independent fixture, such that failures in setting the mgmt IPs won't nuke the testbed. Also refactor / cleanup some other aspects of the tests to enhance clarity.
Summary:
Fixes #16441
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix failures in test setup leaving the testbed in a wedged state, due to removed ipv4 mgmt IPs
How did you do it?
Refactor the test to have config backup and restore in a separate fixture
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation