Increase timeout for wait_bgp_sessions for T2 duts #16438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions for supervisor duts * Add check to increase timeout to 900 if duthost is a supervisor Signed-off-by: Javier Tan [email protected]
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liamkearney-msft
approved these changes
Jan 10, 2025
arlakshm
previously approved these changes
Jan 10, 2025
arlakshm
reviewed
Jan 11, 2025
| @@ -624,6 +624,10 @@ def wait_bgp_sessions(duthost, timeout=120): | |||
| A helper function to wait bgp sessions on DUT | |||
| """ | |||
| bgp_neighbors = duthost.get_bgp_neighbors_per_asic(state="all") | |||
| if duthost.is_supervisor_node(): | |||
There was a problem hiding this comment.
on voq chassis supervisor has no bgp sessions, can we modify the caller to send the needed timeout when wait_bgp_sessions is called for Linecards
…to T2 * Change increase for timeout for supervisor nodes to increase for all T2 duts Signed-off-by: Javier Tan [email protected]
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Javier-Tan
changed the title
Javier-Tan
added
Request for msft-202405 Branch
and removed
Request for 202405 branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes #16436, caused by added BGP check in #15936, which doesn't account for T2 BGP time to come up
Type of change
Back port request
Approach
What is the motivation for this PR?
Function
wait_bgp_sessionstimeout is too short for T2, fails intest_mgmt_ipv6_onlytest suite causing a fixture to error wrongly and not teardown properly leaving TB in bad state without ipv4 mgmt ipHow did you do it?
Increase timeout to 900s from 120s if duthost it is checking is supervisor
How did you verify/test it?
Run locally on T2
See for passing test:
Confirming it needs more than 120 seconds
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A
Documentation
N/A