Add T2 support to test_power_off_reboot.py #16313
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change checking each PDU for power, to checkings sets of PDUs associated to PSU for at least one power * Add duthosts to reboot_and_check for support on sup cards Signed-off-by: Javier Tan [email protected]
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Javier-Tan
changed the title
arlakshm
previously approved these changes
Jan 4, 2025
|
Commenter does not have sufficient privileges for PR 16313 in repo sonic-net/sonic-mgmt |
liamkearney-msft
approved these changes
Jan 5, 2025
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…grouped PDUs * Simplify an iterator operation * Change power_on_seq to use PDUs by PSUs rather than individual PDUs Signed-off-by: Javier Tan [email protected]
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
arlakshm
approved these changes
Jan 11, 2025
Javier-Tan
changed the title
Javier-Tan
added
Request for msft-202405 Branch
and removed
Request for 202405 branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes #16279, update platform_tests/power_off_reboot.py to support T2 devices
Type of change
Back port request
Approach
What is the motivation for this PR?
Test failures on T2 devices
How did you do it?
Change check for power on each PDU to check for power on sets of PDUs (by PSU), add duthosts argument to
reboot_and_checkfunction to support sup cardsHow did you verify/test it?
Perform regression test on T1 https://elastictest.org/scheduler/testplan/677b439de1be6860ea024869?testcase=platform_tests%2Ftest_power_off_reboot.py&type=console
Perform test on T2 to ensure these failures are gone (still failure in #16289)
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A
Documentation