Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] [PR:12735] Add buffer queue counters test case to telemetry test #13207

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

mssonicbld
Copy link
Collaborator

Description of PR

This test is checking that the number of buffer queue counters from telemetry point of view is inline when using create_only_config_db_counters optimization.

Summary:
Accompanies "Fix SNMP dropping some of the queue counter when create_only_config_db_buffers is set to true" (sonic-net/sonic-snmpagent#303) which fixes the issue: "The feature "polling only configured ports buffer queue" will break SNMP" (sonic-net/sonic-buildimage#17448).
Accompanies "Test polling only configured buffer queue counters" #11941

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305
  • 202311

Approach

What is the motivation for this PR?

To enhance the bug fix mentioned above, solving an issue with buffer queue counters optimization.

How did you do it?

  • Set "create_only_config_db_buffers" to true in config db, to create only relevant counters
  • Remove one of the buffer queues, Ethernet0|3-4 is chosen arbitrary
  • Using gnmi to query COUNTERS_QUEUE_NAME_MAP for Ethernet0 compare number of queue counters on Ethernet0. It is expected that it will decrease by the number of deleted queue buffers.

How did you verify/test it?

Run the test multiple times on various setups.

Any platform specific information?

Supported testbed topology if it's a new test case?

Any

Documentation

* Add buffer queue counters test case to telemetry test
@mssonicbld
Copy link
Collaborator Author

Original PR: #12735

@mssonicbld mssonicbld merged commit 62b0dad into sonic-net:202405 Jun 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants