Skip to content

Commit

Permalink
[Chassis] Add extra wait after port toggle so that the routes got pro…
Browse files Browse the repository at this point in the history
…grammed into hardware (#16737)

Description of PR
Summary:
Fixes #30114164

Approach
What is the motivation for this PR?
Fixes #30114164, test_acl is flaky on chassis device.
We observe flakiness failure on chassis devices
Suspect it's because the route is not programmed into hardware
Add external sleep to make sure route is in hardware

How did you do it?
Add extra waiting time for chassis device port toggle tests.

How did you verify/test it?
Run on PR test, and physical test is running.

co-authorized by: [email protected]
  • Loading branch information
yejianquan authored Jan 31, 2025
1 parent ff4583c commit cf19a6e
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion tests/acl/test_acl.py
Original file line number Diff line number Diff line change
Expand Up @@ -1374,5 +1374,12 @@ def post_setup_hook(self, dut, localhost, populate_vlan_arp_entries, tbinfo, con
populate_vlan_arp_entries: A fixture to populate ARP/FDB tables for VLAN interfaces.
"""
port_toggle(dut, tbinfo)
# todo: remove the extra sleep on chassis device after bgp suppress fib pending feature is enabled
# We observe flakiness failure on chassis devices
# Suspect it's because the route is not programmed into hardware
# Add external sleep to make sure route is in hardware
if dut.get_facts().get("modular_chassis"):
port_toggle(dut, tbinfo, wait_after_ports_up=180)
else:
port_toggle(dut, tbinfo)
populate_vlan_arp_entries()

0 comments on commit cf19a6e

Please sign in to comment.