Skip to content

Commit

Permalink
Skip test_warm_reboot_mac_jump and test_warm_reboot_sad in PR testing. (
Browse files Browse the repository at this point in the history
#16572)

What is the motivation for this PR?
In PR #16287, we skipped test_advanced_reboot.py during PR testing but retained the test case test_warm_reboot on the T0 topology. However, the other two test cases, test_warm_reboot_mac_jump and test_warm_reboot_sad, unexpectedly matched the longest entry platform_tests/test_advanced_reboot.py::test_warm_reboot: and were also executed on the T0 topology. To address this issue, this PR applies the conditional mark to skip these two test cases.

How did you do it?
This PR applies the conditional mark to skip these test cases test_warm_reboot_mac_jump and test_warm_reboot_sad.

How did you verify/test it?
Test locally and it can skip test cases as expected.

platform_tests/test_advanced_reboot.py::test_fast_reboot[vlab-02] SKIPPED [ 7%]
platform_tests/test_advanced_reboot.py::test_fast_reboot_from_other_vendor[vlab-02] SKIPPED [ 14%]
platform_tests/test_advanced_reboot.py::test_warm_reboot[single-vlab-02] PASSED [ 21%]
platform_tests/test_advanced_reboot.py::test_warm_reboot[dual-vlab-02] SKIPPED [ 28%]
platform_tests/test_advanced_reboot.py::test_warm_reboot_mac_jump[vlab-02] SKIPPED [ 35%]
platform_tests/test_advanced_reboot.py::test_warm_reboot_sad[sad-vlab-02] SKIPPED [ 42%]
platform_tests/test_advanced_reboot.py::test_warm_reboot_sad[multi_sad-vlab-02] SKIPPED [ 50%]
platform_tests/test_advanced_reboot.py::test_warm_reboot_sad[sad_bgp-vlab-02] SKIPPED [ 57%]
platform_tests/test_advanced_reboot.py::test_warm_reboot_sad[sad_lag_member-vlab-02] SKIPPED [ 64%]
platform_tests/test_advanced_reboot.py::test_warm_reboot_sad[sad_lag-vlab-02] SKIPPED [ 71%]
platform_tests/test_advanced_reboot.py::test_warm_reboot_sad[sad_vlan_port-vlab-02] SKIPPED [ 78%]
platform_tests/test_advanced_reboot.py::test_warm_reboot_sad[sad_inboot-vlab-02] SKIPPED [ 85%]
platform_tests/test_advanced_reboot.py::test_cancelled_fast_reboot[vlab-02] SKIPPED [ 92%]
platform_tests/test_advanced_reboot.py::test_cancelled_warm_reboot[vlab-02] SKIPPED [100%]
  • Loading branch information
yutongzhang-microsoft authored Jan 17, 2025
1 parent 6814013 commit 5054d0a
Showing 1 changed file with 12 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1056,6 +1056,18 @@ platform_tests/test_advanced_reboot.py::test_warm_reboot:
conditions:
- "asic_type in ['vs'] and 't0' not in topo_name"

platform_tests/test_advanced_reboot.py::test_warm_reboot_mac_jump:
skip:
reason: "Skip in PR testing as taking too much time."
conditions:
- "asic_type in ['vs']"

platform_tests/test_advanced_reboot.py::test_warm_reboot_sad:
skip:
reason: "Skip in PR testing as taking too much time."
conditions:
- "asic_type in ['vs']"

#######################################
##### test_cont_warm_reboot.py #####
#######################################
Expand Down

0 comments on commit 5054d0a

Please sign in to comment.