gNOI System APIs (Reboot, RebootStatus, CancelReboot) changes #308
+2,289
−226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
hdwhdw
previously approved these changes
Nov 15, 2024
|
/azp run |
|
Pull request contains merge conflicts. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@ndas7 could you please merge latest repo changes for easy review? Thank you! |
vvolam
reviewed
Jan 21, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 308 in repo sonic-net/sonic-gnmi |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 308 in repo sonic-net/sonic-gnmi |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
hdwhdw
approved these changes
Jan 31, 2025
qiluo-msft
reviewed
Jan 31, 2025
| ) | ||
|
|
||
| // Converts a SWSS error code string into a gRPC code. | ||
| func SwssToErrorCode(statusStr string) codes.Code { |
|
Please resolve conflict |
vvolam
reviewed
Jan 31, 2025
| return &resp, nil | ||
| } | ||
|
|
||
| func HaltSystem() error { |
There was a problem hiding this comment.
@ndas7 As discussed, could you please integrate this commit as well?
Remove old way of HALT Reboot method by vvolam · Pull Request #1 · ndas7/sonic-gnmi?. If you merge the PR, the commit will be integrated to your PR
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Add support for gNOI System APIs for Reboot, RebootStatus, CancelReboot to forward requests to the Reboot Backend through Redis DB Notification channel.
How I did it
Created separate files for the System APIs under gnoi_system.go
How to verify it
Unit tests and build infrastructure checks
Which release branch to backport (provide reason below if selected)
Description for the changelog
Add support for gNOI System APIs for Reboot, RebootStatus, CancelReboot
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)