Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated maven site plugin version and logos #38

Closed
wants to merge 1 commit into from

Conversation

ingokegel
Copy link
Contributor

After #37 a site update is advisable, because the new parameters are quite important, see #30

@jdillon
Copy link
Contributor

jdillon commented Oct 4, 2019

was there any reason for the bytecode level change? its probably fine, and time to generally update to a more recent basis?

@jdillon
Copy link
Contributor

jdillon commented Oct 4, 2019

why was src/site/resources/images/google-analytics.png removed?

@ingokegel
Copy link
Contributor Author

was there any reason for the bytecode level change? its probably fine, and time to generally update to a more recent basis?

I updated it while trying to compile with Java 11, which does not support the 1.5 target anymore.

why was src/site/resources/images/google-analytics.png removed?

Sorry about that, I actually meant to update the logo, but something went wrong, I'll add it again on Monday.

@jdillon jdillon mentioned this pull request Oct 6, 2019
@jdillon
Copy link
Contributor

jdillon commented Oct 6, 2019

@ingokegel I'll just update the image, this project probably needs a bit of love to update all the various bits to modern deps, not sure I'll have time to do that any time soon though.

@jdillon jdillon closed this Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants