Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#139 Allows to set additional scan targets for IQ evaluations #150

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

guillermo-varela
Copy link
Contributor

Allows to set extra paths (or patterns) to scan additional files.

For example:

scanTargets = ['package-lock.json', '**/*.lock']

It relates to the following issue #s:

cc @bhamail / @DarthHater / @shaikhu

@@ -77,11 +77,11 @@ dependencies {
implementation "com.sonatype.nexus:nexus-platform-api:$nexusPlatformApiVersion"
implementation "org.sonatype.ossindex:ossindex-service-client:$ossIndexClientVersion"
implementation "ch.qos.logback:logback-classic:$logbackVersion"
implementation "commons-io:commons-io:$commonsIoVersion"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required to process package-lock.json (and possibly other manifests) files when scanning them.

@@ -166,6 +171,22 @@ private Properties buildProperties() {
return properties;
}

private List<File> buildScanTargets() {
if (extension.getScanTargets() != null && !extension.getScanTargets().isEmpty()) {
// Using the same approach as the Jenkins plugin for consistency
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guillermo-varela guillermo-varela marked this pull request as ready for review January 19, 2024 00:01
@guillermo-varela guillermo-varela merged commit edb4449 into main Jan 19, 2024
10 checks passed
@guillermo-varela guillermo-varela deleted the #139_scan_targets branch January 19, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] add ability to scan npm / scan targets
1 participant