Skip to content

Commit

Permalink
Add test for null route in callbacks
Browse files Browse the repository at this point in the history
  • Loading branch information
ashishb-solo committed Sep 30, 2024
1 parent 690f908 commit 2e69711
Showing 1 changed file with 19 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1238,6 +1238,25 @@ TEST_F(InjaTransformerTest, ParseFromClusterMetadata) {
EXPECT_EQ(body.toString(), "val");
}

TEST_F(InjaTransformerTest, SetSpanNameNullRoute) {
std::string transformer_span_name = "TRANSFORMER_SPAN_NAME";
TransformationTemplate transformation;
transformation.mutable_span_transformer()->mutable_name()->set_text(transformer_span_name);

Http::TestRequestHeaderMapImpl headers{};
Buffer::OwnedImpl body("");
NiceMock<Http::MockStreamDecoderFilterCallbacks> callbacks;

InjaTransformer transformer(transformation, rng_, google::protobuf::BoolValue(), tls_);
std::unique_ptr<Tracing::MockSpan> mock_span = std::make_unique<Tracing::MockSpan>();
const std::unique_ptr<Router::MockDecorator> mock_decorator = std::make_unique<NiceMock<Router::MockDecorator>>();
ON_CALL(callbacks, route).WillByDefault(Return(nullptr));
EXPECT_CALL(callbacks, activeSpan).WillOnce(ReturnRef(*mock_span));
EXPECT_CALL(*mock_span, setOperation(transformer_span_name)).Times(1);

transformer.transform(headers, &headers, body, callbacks);
}

TEST_F(InjaTransformerTest, SetSpanNameNullRouteDecorator) {
std::string transformer_span_name = "TRANSFORMER_SPAN_NAME";
TransformationTemplate transformation;
Expand Down

0 comments on commit 2e69711

Please sign in to comment.