Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove props.children from button readme #67

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Conversation

thetarnav
Copy link
Member

Children are being passed down with the buttonProps, no need to apply them twice.

Children are being passed down with the `buttonProps`, no need to apply them twice.
@changeset-bot
Copy link

changeset-bot bot commented Aug 31, 2022

⚠️ No Changeset found

Latest commit: 2201b81

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@thetarnav
Copy link
Member Author

Actually because of #69 it doesn't actually work xd

@fabien-ml fabien-ml changed the base branch from main to develop August 31, 2022 18:55
@fabien-ml fabien-ml merged commit 0989ada into develop Aug 31, 2022
@thetarnav thetarnav deleted the thetarnav-patch-1 branch September 2, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants