-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable select all seedlots in available seedlots dialog #5160
Conversation
…toggled, all checkboxes in the open available seedlots modal are selected/deselected. List creation works. Disabled checkboxes are ignored.
Hi Ryan, this looks really nice - I only had one minor comment: in the case where someone selects a list made up entirely of accessions that don't have any available seedlots, the Select All box is still enabled and clickable, which could be misleading. In that scenario, it might be good to have it disabled in the same way that the check boxes are for the individual accessions in the list. |
Ok, I will change it to hide the select all button if the seedlots list is empty |
…no seedlots are available to be selected from list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
…toggled, all checkboxes in the open available seedlots modal are selected/deselected. List creation works. Disabled checkboxes are ignored.
Description
Added a javascript function to enable users to select/deselect all available seedlots in the available seedlots modal. Disabled seedlots are ignored. Works with list creation.
Checklist
/t/data/fixture/patches/
./docs
has been updated./js
to/js/source/legacy
.