Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable select all seedlots in available seedlots dialog #5160

Merged
merged 4 commits into from
Oct 31, 2024

Conversation

ryan-preble
Copy link
Contributor

…toggled, all checkboxes in the open available seedlots modal are selected/deselected. List creation works. Disabled checkboxes are ignored.

Description

Added a javascript function to enable users to select/deselect all available seedlots in the available seedlots modal. Disabled seedlots are ignored. Works with list creation.

Checklist

  • Refactoring only
  • Documentation only
  • Fixture update only
  • Bug fix
    • The relevant issue has been closed.
    • Further work is required.
  • New feature
    • Relevant tests have been created and run.
    • Data was added to the fixture
      • Data was added via a patch in /t/data/fixture/patches/.
    • User-Facing Change
      • The user manual in /docs has been updated.
    • Any new Perl has been documented using perldoc.
    • Any new JavaScript has been documented using JSDoc.
    • Any new legacy JavaScript has been moved from /js to /js/source/legacy.

…toggled, all checkboxes in the open available seedlots modal are selected/deselected. List creation works. Disabled checkboxes are ignored.
@ryan-preble ryan-preble changed the title Changes to available_seedlots.mas to add a Select All checkbox. When … Enable select all seedlots in available seedlots dialog Oct 21, 2024
@Sri-2023 Sri-2023 requested review from alockrow, Sri-2023 and afpowell and removed request for alockrow October 24, 2024 15:16
@afpowell
Copy link
Contributor

Hi Ryan, this looks really nice - I only had one minor comment: in the case where someone selects a list made up entirely of accessions that don't have any available seedlots, the Select All box is still enabled and clickable, which could be misleading. In that scenario, it might be good to have it disabled in the same way that the check boxes are for the individual accessions in the list.

@ryan-preble
Copy link
Contributor Author

Hi Ryan, this looks really nice - I only had one minor comment: in the case where someone selects a list made up entirely of accessions that don't have any available seedlots, the Select All box is still enabled and clickable, which could be misleading. In that scenario, it might be good to have it disabled in the same way that the check boxes are for the individual accessions in the list.

Ok, I will change it to hide the select all button if the seedlots list is empty

Copy link
Contributor

@afpowell afpowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@Sri-2023 Sri-2023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lukasmueller lukasmueller merged commit 11a89ce into master Oct 31, 2024
3 checks passed
@lukasmueller lukasmueller deleted the 5089_seedplots_select_all branch October 31, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants