Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local-cluster: ignore test_duplicate_shreds_switch_failure #34267

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

AshwinSekar
Copy link
Contributor

Problem

test_duplicate_shreds_switch_failure is flaky - see #34212

Summary of Changes

#[ignore] it for now, while I put together a proper fix

Copy link
Contributor

@apfitzge apfitzge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - allows others to not get hit by flaky CI while a fix is worked on.

@AshwinSekar AshwinSekar added the automerge Merge this Pull Request automatically once CI passes label Nov 29, 2023
Copy link
Contributor

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm cool with this seeing as you already self-assigned yourself to #34212

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #34267 (2a228a4) into master (e1165aa) will increase coverage by 0.0%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #34267   +/-   ##
=======================================
  Coverage    81.9%    81.9%           
=======================================
  Files         819      819           
  Lines      219665   219665           
=======================================
+ Hits       179946   179990   +44     
+ Misses      39719    39675   -44     

@mergify mergify bot merged commit 60c09d3 into solana-labs:master Nov 29, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants