NFT Plugin: Add on-chain collection size preference #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielhicks
commented
Jul 6, 2022
•
gabrielhicks
commented
- Bump Anchor versions from 0.24.2 => 0.25.0
- Added a preference for on-chain collection size that was integrated via CollectionDetails::V1 in mpl_token_metadata 1.3.1
- Changed configure_collection "size" argument from u32 => u64
- Tests written to verify size is pulled from collection details
- ./fixtures/mpl_token_metadata.so updated to 1.3.1
gabrielhicks
changed the title
gabrielhicks
changed the title
gabrielhicks
changed the title
|
Hey @SebastianBor if you get an opportunity would you mind reviewing this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.